Bug 186117

Summary: [LFC] Layout code needs to know the type of the Element associated with a Layout::Box
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2018-05-30 16:31:52 PDT
for example we need to know if the box is associated with the <body> and size it differently in quirks mode.
Attachments
Patch (15.20 KB, patch)
2018-05-30 16:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.10 KB, patch)
2018-05-31 09:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-05-30 16:39:03 PDT
Created attachment 341620 [details] Patch
Antti Koivisto
Comment 2 2018-05-31 07:35:03 PDT
Comment on attachment 341620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341620&action=review > Source/WebCore/layout/layouttree/LayoutBox.h:120 > + struct ElementAttributes { > + ElementAttributes(ElementType elementType) > + : elementType(elementType) > + { > + } > + > + ElementType elementType; > + }; Indentation for { } is wrong. Is the constructor needed? Maybe this could just use bracket initialization?
alan
Comment 3 2018-05-31 09:14:54 PDT
Created attachment 341666 [details] Patch
WebKit Commit Bot
Comment 4 2018-05-31 09:43:58 PDT
Comment on attachment 341666 [details] Patch Clearing flags on attachment: 341666 Committed r232350: <https://trac.webkit.org/changeset/232350>
WebKit Commit Bot
Comment 5 2018-05-31 09:43:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-05-31 09:52:03 PDT
<rdar://problem/40688526>
Note You need to log in before you can comment on or make changes to this bug.