Summary: | Block more ports (427, 548, 6697) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anne van Kesteren <annevk> | ||||||||||
Component: | DOM | Assignee: | Rob Buis <rbuis> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, cdumez, ews-watchlist, fred.wang, rbuis, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Anne van Kesteren
2018-05-30 07:27:41 PDT
Created attachment 355528 [details]
Patch
Attachment 355528 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/URL.cpp:922: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 355528 [details] Patch Attachment 355528 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10126662 New failing tests: media/no-fullscreen-when-hidden.html Created attachment 355559 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 355600 [details]
Patch
Attachment 355600 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/URL.cpp:922: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 355600 [details]
Patch
The style error is a bit silly and I think we can ignore it.
Comment on attachment 355600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355600&action=review > Source/WebCore/ChangeLog:8 > + Block port 427. Maybe explain a bit more. In particular that 548 and 6697 are already blocked, we just extend WPT coverage to verify these ports too. > LayoutTests/imported/w3c/ChangeLog:8 > + Update equest-bad-port.html to latest version. request-bad-port.html Created attachment 355655 [details]
Patch
Attachment 355655 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/URL.cpp:922: One space before end of line comments [whitespace/comments] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Landed as r238604. |