Bug 186088

Summary: Make WKWebView firstResponder after entering or exiting fullscreen.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jeremy Jones 2018-05-30 04:25:21 PDT 
Make WKWebView firstResponder after entering or exiting fullscreen.
Comment 1 Jeremy Jones 2018-05-30 04:25:46 PDT 
*** Bug 186087 has been marked as a duplicate of this bug. ***
Comment 2 Jeremy Jones 2018-05-30 04:27:13 PDT 
rdar://problem/40387859
Comment 3 Jeremy Jones 2018-05-30 04:31:51 PDT 
Created attachment 341561 [details]
Patch
Comment 4 Jon Lee 2018-05-30 07:56:59 PDT 
Comment on attachment 341561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341561&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538
> +            [webView becomeFirstResponder];

This block inconsistently references the web view with a local variable and a member variable. Which one should it be?
Comment 5 Jeremy Jones 2018-06-01 16:50:24 PDT 
Created attachment 341806 [details]
Patch
Comment 6 Jeremy Jones 2018-06-01 17:02:51 PDT 
(In reply to Jon Lee from comment #4)
> Comment on attachment 341561 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341561&action=review
> 
> > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538
> > +            [webView becomeFirstResponder];
> 
> This block inconsistently references the web view with a local variable and
> a member variable. Which one should it be?

Fixed.
Comment 7 WebKit Commit Bot 2018-06-02 09:03:36 PDT 
Comment on attachment 341806 [details]
Patch

Clearing flags on attachment: 341806

Committed r232438: <https://trac.webkit.org/changeset/232438>
Comment 8 WebKit Commit Bot 2018-06-02 09:03:38 PDT 
All reviewed patches have been landed.  Closing bug.