Bug 186088

Summary: Make WKWebView firstResponder after entering or exiting fullscreen.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jeremy Jones
Reported 2018-05-30 04:25:21 PDT
Make WKWebView firstResponder after entering or exiting fullscreen.
Attachments
Patch (2.04 KB, patch)
2018-05-30 04:31 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (2.05 KB, patch)
2018-06-01 16:50 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2018-05-30 04:25:46 PDT
*** Bug 186087 has been marked as a duplicate of this bug. ***
Jeremy Jones
Comment 2 2018-05-30 04:27:13 PDT
rdar://problem/40387859
Jeremy Jones
Comment 3 2018-05-30 04:31:51 PDT
Created attachment 341561 [details] Patch
Jon Lee
Comment 4 2018-05-30 07:56:59 PDT
Comment on attachment 341561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341561&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538 > + [webView becomeFirstResponder]; This block inconsistently references the web view with a local variable and a member variable. Which one should it be?
Jeremy Jones
Comment 5 2018-06-01 16:50:24 PDT
Created attachment 341806 [details] Patch
Jeremy Jones
Comment 6 2018-06-01 17:02:51 PDT
(In reply to Jon Lee from comment #4) > Comment on attachment 341561 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341561&action=review > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538 > > + [webView becomeFirstResponder]; > > This block inconsistently references the web view with a local variable and > a member variable. Which one should it be? Fixed.
WebKit Commit Bot
Comment 7 2018-06-02 09:03:36 PDT
Comment on attachment 341806 [details] Patch Clearing flags on attachment: 341806 Committed r232438: <https://trac.webkit.org/changeset/232438>
WebKit Commit Bot
Comment 8 2018-06-02 09:03:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.