Bug 186085

Summary:

[JSC] Pass VM& parameter as much as possible

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, commit-queue, ews-watchlist, joepeck, jsbell, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Yusuke Suzuki

Reported 2018-05-30 02:43:37 PDT

[JSC] Pass VM& parameter as much as possible

Attachments
Patch (296.73 KB, patch) 2018-05-30 02:47 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (296.56 KB, patch) 2018-05-30 05:43 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-05-30 02:47:47 PDT

Created attachment 341560 [details] Patch

EWS Watchlist

Comment 2 2018-05-30 02:51:20 PDT

Attachment 341560 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:363: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 168 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-05-30 04:09:26 PDT

Comment on attachment 341560 [details] Patch Attachment 341560 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/7862299 New failing tests: wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-slow-memory wasm.yaml/wasm/function-tests/context-switch.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/select.wast.js.default-wasm wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/exceptions.js.default-wasm wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/exceptions.js.wasm-slow-memory wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-call-ic wasm.yaml/wasm/js-api/wrapper-function.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/grow-memory-3.js.default-wasm wasm.yaml/wasm/function-tests/context-switch.js.wasm-slow-memory wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/start.wast.js.default-wasm wasm.yaml/wasm/fuzz/memory.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/fuzz/memory.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/call_indirect.wast.js.default-wasm wasm.yaml/wasm/fuzz/memory.js.default-wasm wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/resizing.wast.js.default-wasm wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/factorial.js.default-wasm wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/stack-overflow.js.default-wasm wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-eager-jettison wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-tls-context wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/unreachable.wast.js.default-wasm wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-store.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/address.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/factorial.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-load.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/exceptions.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-slow-memory wasm.yaml/wasm/fuzz/memory.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-slow-memory wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/call.wast.js.default-wasm wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-load.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.default-wasm wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-call-ic wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/linking.wast.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.default-wasm wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.default-wasm wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/unwind.wast.js.default-wasm wasm.yaml/wasm/fuzz/memory.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/js-api/wrapper-function.js.default-wasm wasm.yaml/wasm/fuzz/memory.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-load-2.js.default-wasm wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/context-switch.js.default-wasm wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-from-start-async.js.default-wasm wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/conversions.wast.js.default-wasm wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/factorial.js.wasm-slow-memory wasm.yaml/wasm/function-tests/trap-load.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-store.js.default-wasm wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-tls-context wasm.yaml/wasm/js-api/wrapper-function.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/memory-reuse.js.default-wasm wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/traps.wast.js.default-wasm wasm.yaml/wasm/function-tests/factorial.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/start.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/i64.wast.js.default-wasm wasm.yaml/wasm/function-tests/factorial.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/trap-store-2.js.default-wasm wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-eager-jettison wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/fac.wast.js.default-wasm wasm.yaml/wasm/spec-tests/int_exprs.wast.js.default-wasm wasm.yaml/wasm/spec-tests/memory_trap.wast.js.default-wasm wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/select.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/imports.wast.js.default-wasm wasm.yaml/wasm/function-tests/trap-store.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-call-ic wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/address.wast.js.default-wasm wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-tls-context wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-cjit-yes-tls-context wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-slow-memory wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-tls-context wasm.yaml/wasm/function-tests/factorial.js.wasm-no-call-ic wasm.yaml/wasm/spec-tests/i32.wast.js.default-wasm wasm.yaml/wasm/spec-tests/call.wast.js.wasm-eager-jettison wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-call-ic

Yusuke Suzuki

Comment 4 2018-05-30 05:43:12 PDT

Created attachment 341563 [details] Patch

EWS Watchlist

Comment 5 2018-05-30 05:46:18 PDT

Attachment 341563 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:363: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 168 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 6 2018-05-30 21:40:38 PDT

Comment on attachment 341563 [details] Patch rs=me

Yusuke Suzuki

Comment 7 2018-05-30 22:52:04 PDT

Comment on attachment 341563 [details] Patch Thanks!

WebKit Commit Bot

Comment 8 2018-05-30 23:19:41 PDT

Comment on attachment 341563 [details] Patch Clearing flags on attachment: 341563 Committed r232337: <https://trac.webkit.org/changeset/232337>

WebKit Commit Bot

Comment 9 2018-05-30 23:19:43 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2018-05-30 23:33:45 PDT

<rdar://problem/40676373>

Note You need to log in before you can comment on or make changes to this bug.