186085 – [JSC] Pass VM& parameter as much as possible

Bug 186085 - [JSC] Pass VM& parameter as much as possible

Summary: [JSC] Pass VM& parameter as much as possible

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Yusuke Suzuki

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-05-30 02:43 PDT by Yusuke Suzuki
Modified:	2018-05-30 23:33 PDT (History)
CC List:	11 users (show)

See Also:

Attachments
Patch (296.73 KB, patch) 2018-05-30 02:47 PDT, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Patch (296.56 KB, patch) 2018-05-30 05:43 PDT, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yusuke Suzuki 2018-05-30 02:43:37 PDT

[JSC] Pass VM& parameter as much as possible

Comment 1 Yusuke Suzuki 2018-05-30 02:47:47 PDT

Created attachment 341560 [details]
Patch

Comment 2 EWS Watchlist 2018-05-30 02:51:20 PDT

Attachment 341560 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:363:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 168 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EWS Watchlist 2018-05-30 04:09:26 PDT

Comment on attachment 341560 [details]
Patch

Attachment 341560 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7862299

New failing tests:
wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/context-switch.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/select.wast.js.default-wasm
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/exceptions.js.default-wasm
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/exceptions.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-call-ic
wasm.yaml/wasm/js-api/wrapper-function.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/grow-memory-3.js.default-wasm
wasm.yaml/wasm/function-tests/context-switch.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/start.wast.js.default-wasm
wasm.yaml/wasm/fuzz/memory.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/fuzz/memory.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/call_indirect.wast.js.default-wasm
wasm.yaml/wasm/fuzz/memory.js.default-wasm
wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/resizing.wast.js.default-wasm
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/factorial.js.default-wasm
wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/stack-overflow.js.default-wasm
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-eager-jettison
wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-no-tls-context
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/unreachable.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-store.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/address.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/factorial.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-load.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/exceptions.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-slow-memory
wasm.yaml/wasm/fuzz/memory.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/start.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/call.wast.js.default-wasm
wasm.yaml/wasm/js-api/wrapper-function.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-load.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.default-wasm
wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-call-ic
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/linking.wast.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/i32.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/call_indirect.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-load-2.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.default-wasm
wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js.default-wasm
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/address.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/unwind.wast.js.default-wasm
wasm.yaml/wasm/fuzz/memory.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/js-api/wrapper-function.js.default-wasm
wasm.yaml/wasm/fuzz/memory.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/call.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-load-2.js.default-wasm
wasm.yaml/wasm/spec-tests/unwind.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/linking.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/context-switch.js.default-wasm
wasm.yaml/wasm/spec-tests/traps.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-from-start-async.js.default-wasm
wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/conversions.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/memory_trap.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/factorial.js.wasm-slow-memory
wasm.yaml/wasm/function-tests/trap-load.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/imports.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-store.js.default-wasm
wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/stack-overflow.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-store.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-tls-context
wasm.yaml/wasm/js-api/wrapper-function.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-after-cross-instance-call.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/memory-reuse.js.default-wasm
wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/traps.wast.js.default-wasm
wasm.yaml/wasm/function-tests/factorial.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/i64.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/start.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-from-start-async.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/i64.wast.js.default-wasm
wasm.yaml/wasm/function-tests/factorial.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/resizing.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/trap-store-2.js.default-wasm
wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-eager-jettison
wasm.yaml/wasm/spec-tests/select.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/fac.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/int_exprs.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/memory_trap.wast.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/grow-memory-3.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/select.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/exceptions.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/imports.wast.js.default-wasm
wasm.yaml/wasm/function-tests/trap-store.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/fac.wast.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/int_exprs.wast.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/memory-access-past-4gib.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-store-2.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-load.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/address.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/skip-stack-guard-page.wast.js.wasm-no-tls-context
wasm.yaml/wasm/spec-tests/conversions.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/spec-tests/unreachable.wast.js.wasm-no-cjit-yes-tls-context
wasm.yaml/wasm/function-tests/memory-reuse.js.wasm-slow-memory
wasm.yaml/wasm/spec-tests/func_ptrs.wast.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/factorial.js.wasm-no-call-ic
wasm.yaml/wasm/spec-tests/i32.wast.js.default-wasm
wasm.yaml/wasm/spec-tests/call.wast.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/context-switch.js.wasm-no-call-ic

Comment 4 Yusuke Suzuki 2018-05-30 05:43:12 PDT

Created attachment 341563 [details]
Patch

Comment 5 EWS Watchlist 2018-05-30 05:46:18 PDT

Attachment 341563 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:363:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 168 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Saam Barati 2018-05-30 21:40:38 PDT

Comment on attachment 341563 [details]
Patch

rs=me

Comment 7 Yusuke Suzuki 2018-05-30 22:52:04 PDT

Comment on attachment 341563 [details]
Patch

Thanks!

Comment 8 WebKit Commit Bot 2018-05-30 23:19:41 PDT

Comment on attachment 341563 [details]
Patch

Clearing flags on attachment: 341563

Committed r232337: <https://trac.webkit.org/changeset/232337>

Comment 9 WebKit Commit Bot 2018-05-30 23:19:43 PDT

All reviewed patches have been landed.  Closing bug.

Comment 10 Radar WebKit Bug Importer 2018-05-30 23:33:45 PDT

<rdar://problem/40676373>