Bug 186083

Summary: [LFC] Miscellaneous fixes to get closer to geometry correctness
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2018-05-29 22:00:03 PDT 
when laying out <div></div>
Comment 1 zalan 2018-05-30 07:32:50 PDT 
Created attachment 341569 [details]
Patch
Comment 2 Antti Koivisto 2018-05-30 07:41:45 PDT 
Comment on attachment 341569 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341569&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:120
> +    auto width = [&]() {

computeWidth() maybe? width() sounds like an accessor.
Comment 3 zalan 2018-05-30 07:47:33 PDT 
Created attachment 341573 [details]
Patch
Comment 4 zalan 2018-05-30 07:58:27 PDT 
Created attachment 341574 [details]
Patch
Comment 5 WebKit Commit Bot 2018-05-30 08:26:56 PDT 
Comment on attachment 341574 [details]
Patch

Clearing flags on attachment: 341574

Committed r232291: <https://trac.webkit.org/changeset/232291>
Comment 6 WebKit Commit Bot 2018-05-30 08:26:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-30 08:27:17 PDT 
<rdar://problem/40650779>