Bug 186083

Summary: [LFC] Miscellaneous fixes to get closer to geometry correctness
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2018-05-29 22:00:03 PDT
when laying out <div></div>
Attachments
Patch (19.03 KB, patch)
2018-05-30 07:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (19.05 KB, patch)
2018-05-30 07:47 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (19.08 KB, patch)
2018-05-30 07:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-05-30 07:32:50 PDT
Created attachment 341569 [details] Patch
Antti Koivisto
Comment 2 2018-05-30 07:41:45 PDT
Comment on attachment 341569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341569&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:120 > + auto width = [&]() { computeWidth() maybe? width() sounds like an accessor.
alan
Comment 3 2018-05-30 07:47:33 PDT
Created attachment 341573 [details] Patch
alan
Comment 4 2018-05-30 07:58:27 PDT
Created attachment 341574 [details] Patch
WebKit Commit Bot
Comment 5 2018-05-30 08:26:56 PDT
Comment on attachment 341574 [details] Patch Clearing flags on attachment: 341574 Committed r232291: <https://trac.webkit.org/changeset/232291>
WebKit Commit Bot
Comment 6 2018-05-30 08:26:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-30 08:27:17 PDT
<rdar://problem/40650779>
Note You need to log in before you can comment on or make changes to this bug.