Bug 186079

Summary: [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ews-watchlist, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184770    
Attachments:
Description Flags
Patch achristensen: review+

Fujii Hironori
Reported 2018-05-29 20:19:27 PDT
[Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp This is a sub task of Bug 184770.
Attachments
Patch (25.20 KB, patch)
2018-05-29 20:38 PDT, Fujii Hironori 		achristensen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-05-29 20:38:13 PDT
Created attachment 341553 [details] Patch
EWS Watchlist
Comment 2 2018-05-29 20:40:06 PDT
Attachment 341553 [details] did not pass style-queue: ERROR: Tools/MiniBrowser/win/Common.cpp:29: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/MiniBrowser/win/Common.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/MiniBrowser/win/WinMain.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/MiniBrowser/win/Common.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Fujii Hironori
Comment 3 2018-05-30 14:36:29 PDT
Could you review?
Alex Christensen
Comment 4 2018-05-30 14:47:33 PDT
Comment on attachment 341553 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341553&action=review > Tools/MiniBrowser/win/WinMain.cpp:-33 > -#include "Common.cpp" !
Fujii Hironori
Comment 5 2018-05-30 20:31:44 PDT
Committed r232333: <https://trac.webkit.org/changeset/232333>
Radar WebKit Bug Importer
Comment 6 2018-05-30 20:36:58 PDT
<rdar://problem/40673691>
Note You need to log in before you can comment on or make changes to this bug.