Bug 186064

Summary: Add a version of JSVirtualMachine shrinkFootprint that runs when the VM goes idle
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2018-05-29 15:11:42 PDT
This will give us a better opportunity at freeing memory in the GC since we can't delete all code until the VM goes idle.
Attachments
patch (3.59 KB, patch)
2018-05-29 15:32 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (5.74 KB, patch)
2018-05-29 16:38 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (5.76 KB, patch)
2018-05-29 19:24 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-05-29 15:32:31 PDT
Created attachment 341529 [details] patch
Saam Barati
Comment 2 2018-05-29 16:38:05 PDT
Created attachment 341536 [details] patch
Mark Lam
Comment 3 2018-05-29 16:41:14 PDT
Comment on attachment 341536 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=341536&action=review r=me > Source/JavaScriptCore/runtime/VM.cpp:785 > + heap.collectNow(Synchronousness::Sync); This didn't pick up your Full GC fix.
Saam Barati
Comment 4 2018-05-29 16:44:27 PDT
Comment on attachment 341536 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=341536&action=review >> Source/JavaScriptCore/runtime/VM.cpp:785 >> + heap.collectNow(Synchronousness::Sync); > > This didn't pick up your Full GC fix. Good catch. Will fix.
Saam Barati
Comment 5 2018-05-29 19:24:38 PDT
Created attachment 341548 [details] patch for landing
WebKit Commit Bot
Comment 6 2018-05-29 21:36:12 PDT
Comment on attachment 341548 [details] patch for landing Clearing flags on attachment: 341548 Committed r232286: <https://trac.webkit.org/changeset/232286>
WebKit Commit Bot
Comment 7 2018-05-29 21:36:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-05-29 21:37:25 PDT
<rdar://problem/40639828>
Note You need to log in before you can comment on or make changes to this bug.