| Summary: | Disable keyboard in fullscreen ios. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||||
| Component: | WebKit2 | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, jer.noble, jonlee, rniwa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jeremy Jones
2018-05-29 13:34:51 PDT
Created attachment 341509 [details]
Patch
Comment on attachment 341509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review > Source/WebKit/ChangeLog:8 > + Disallow keyboard in ios fullscreen. This will still allow select keys useful for playback. Can we add a layout test for this? Comment on attachment 341509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review > Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:104 > void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports) Who are the callers of this function? At first glance you wouldn't know that returning false here means "we support keyboard, just none of the alphanumeric keys". It would be nice to clarify that either in the bool param name or the function name. Comment on attachment 341509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341509&action=review > Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:107 > + supports = false; This is incorrect. It should be: supports = !withKeyboard; Created attachment 341804 [details]
Patch
Comment on attachment 341804 [details] Patch Attachment 341804 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7937783 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html Created attachment 341816 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 341804 [details] Patch Clearing flags on attachment: 341804 Committed r232471: <https://trac.webkit.org/changeset/232471> All reviewed patches have been landed. Closing bug. |