Bug 186057

Summary: Add a consistency check between URL and CFURL
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, realdawei, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2018-05-29 11:08:24 PDT
Tightening URL and CFURL relationship is a healthy measure
Attachments
Patch (11.28 KB, patch)
2018-05-29 11:40 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.69 KB, patch)
2018-05-29 15:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.69 KB, patch)
2018-05-29 16:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-05-29 11:40:35 PDT
Created attachment 341500 [details] Patch
youenn fablet
Comment 2 2018-05-29 15:16:19 PDT
Created attachment 341524 [details] Patch
WebKit Commit Bot
Comment 3 2018-05-29 16:18:25 PDT
Comment on attachment 341524 [details] Patch Rejecting attachment 341524 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 341524, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/7852191
youenn fablet
Comment 4 2018-05-29 16:49:53 PDT
Created attachment 341537 [details] Patch
WebKit Commit Bot
Comment 5 2018-05-29 17:18:46 PDT
Comment on attachment 341537 [details] Patch Clearing flags on attachment: 341537 Committed r232281: <https://trac.webkit.org/changeset/232281>
WebKit Commit Bot
Comment 6 2018-05-29 17:18:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-29 17:22:52 PDT
<rdar://problem/40635192>
Dawei Fenton (:realdawei)
Comment 8 2018-05-30 10:41:27 PDT
This patch may have caused some API test failures: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4781/steps/run-api-tests/logs/stdio
youenn fablet
Comment 9 2018-05-30 14:23:04 PDT
(In reply to David Fenton from comment #8) > This patch may have caused some API test failures: > > https://build.webkit.org/builders/ > Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4781/steps/run- > api-tests/logs/stdio Fixing them in https://bugs.webkit.org/show_bug.cgi?id=186108
Note You need to log in before you can comment on or make changes to this bug.