Bug 186057 - Add a consistency check between URL and CFURL
Summary: Add a consistency check between URL and CFURL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-29 11:08 PDT by youenn fablet
Modified: 2018-05-30 14:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (11.28 KB, patch)
2018-05-29 11:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.69 KB, patch)
2018-05-29 15:16 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.69 KB, patch)
2018-05-29 16:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-05-29 11:08:24 PDT 
Tightening URL and CFURL relationship is a healthy measure
Comment 1 youenn fablet 2018-05-29 11:40:35 PDT 
Created attachment 341500 [details]
Patch
Comment 2 youenn fablet 2018-05-29 15:16:19 PDT 
Created attachment 341524 [details]
Patch
Comment 3 WebKit Commit Bot 2018-05-29 16:18:25 PDT 
Comment on attachment 341524 [details]
Patch

Rejecting attachment 341524 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 341524, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/7852191
Comment 4 youenn fablet 2018-05-29 16:49:53 PDT 
Created attachment 341537 [details]
Patch
Comment 5 WebKit Commit Bot 2018-05-29 17:18:46 PDT 
Comment on attachment 341537 [details]
Patch

Clearing flags on attachment: 341537

Committed r232281: <https://trac.webkit.org/changeset/232281>
Comment 6 WebKit Commit Bot 2018-05-29 17:18:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-29 17:22:52 PDT 
<rdar://problem/40635192>
Comment 8 Dawei Fenton (:realdawei) 2018-05-30 10:41:27 PDT 
This patch may have caused some API test failures:

https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4781/steps/run-api-tests/logs/stdio
Comment 9 youenn fablet 2018-05-30 14:23:04 PDT 
(In reply to David Fenton from comment #8)
> This patch may have caused some API test failures:
> 
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4781/steps/run-
> api-tests/logs/stdio

Fixing them in https://bugs.webkit.org/show_bug.cgi?id=186108