Bug 186020

Summary:

[JSC] Remove ENABLE_INTL flag

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

achristensen, bfulgham, loic.yhuel, mcatanzaro, olivier.blin, ross.kirsling

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review-

Yusuke Suzuki

Reported 2018-05-27 09:12:15 PDT

[JSC] Remove ENABLE_INTL flag

Attachments
Patch (99.68 KB, patch) 2018-05-27 09:14 PDT, Yusuke Suzuki	mcatanzaro: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2018-05-27 09:14:44 PDT

Created attachment 341422 [details] Patch

Yusuke Suzuki

Comment 2 2018-05-27 09:16:34 PDT

This patch enables AppleWin's INTL feature. I'm not sure why this is disabled for AppleWin.

Yusuke Suzuki

Comment 3 2018-05-27 09:17:49 PDT

@bfulgham, @achristensen do you know why AppleWin do not support ENABLE(INTL)?

Olivier Blin

Comment 4 2018-05-28 09:22:22 PDT

ENABLE(INTL) requires at least udat and unum support in ICU. We usually do not enable this in the ICU library that we ship in our embedded devices (set-top box), used by QtWebKit and WPE. udat and unum resources make the ICU library much bigger.

Michael Catanzaro

Comment 5 2018-05-28 18:43:13 PDT

I guess I'd favor keeping the flag forever, then, if we're OK with doing that. And making it PUBLIC for WPE. We should definitely remove it if we do not make it PUBLIC in at least one port.

Michael Catanzaro

Comment 6 2018-05-28 19:19:52 PDT

Comment on attachment 341422 [details] Patch r- for now, we can either discuss further, or make it public for WPE and move on.

Yusuke Suzuki

Comment 7 2018-05-30 06:48:03 PDT

(In reply to Michael Catanzaro from comment #6) > Comment on attachment 341422 [details] > Patch > > r- for now, we can either discuss further, or make it public for WPE and > move on. Hm, it's sad. Can we build ICU with udat & unum with empty data? If we can do that, we can remove ENABLE(INTL) things while we can keep ICU small.

Olivier Blin

Comment 8 2018-05-31 03:52:50 PDT

(In reply to Yusuke Suzuki from comment #7) > Hm, it's sad. Can we build ICU with udat & unum with empty data? > If we can do that, we can remove ENABLE(INTL) things while we can keep ICU > small. Yes, I have to check this, I agree it would be best. IIRC, it was difficult with older ICU releases, but it's probaly different now.

Michael Catanzaro

Comment 9 2018-07-02 06:26:15 PDT

*** Bug 178663 has been marked as a duplicate of this bug. ***

Ross Kirsling

Comment 10 2020-04-14 18:03:38 PDT

*** This bug has been marked as a duplicate of bug 210164 ***

Note You need to log in before you can comment on or make changes to this bug.