Bug 186018

Summary: [LFC] Add layout tree verification.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2018-05-27 07:43:08 PDT
Compare with the render tree geometry and output the mismatched rectangles.
Attachments
Patch (22.08 KB, patch)
2018-05-27 08:02 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (22.04 KB, patch)
2018-05-28 09:46 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.99 KB, patch)
2018-05-28 10:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-05-27 08:02:40 PDT
Created attachment 341421 [details] Patch
alan
Comment 2 2018-05-28 09:46:08 PDT
Created attachment 341456 [details] Patch
Antti Koivisto
Comment 3 2018-05-28 10:00:51 PDT
Comment on attachment 341456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341456&action=review > Source/WebCore/layout/Verification.cpp:44 > + auto outputRect = [&stream, &renderer, &layoutBox, &firstMismatchingRect] (const String& prefix, const LayoutRect& rendererRect, const LayoutRect& layoutRect) { Maybe just [&]?
alan
Comment 4 2018-05-28 10:15:37 PDT
Created attachment 341457 [details] Patch
WebKit Commit Bot
Comment 5 2018-05-28 10:55:23 PDT
Comment on attachment 341457 [details] Patch Clearing flags on attachment: 341457 Committed r232248: <https://trac.webkit.org/changeset/232248>
WebKit Commit Bot
Comment 6 2018-05-28 10:55:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-28 10:56:26 PDT
<rdar://problem/40600664>
Note You need to log in before you can comment on or make changes to this bug.