Bug 186016

Summary:

[Cocoa] Avoid importing directly from subumbrella frameworks

Product:

WebKit

Reporter:

mitz

Component:

WebKit Misc.

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, commit-queue, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

193407

Bug Blocks:

Attachments:

Description	Flags
Patch to see if anything breaks	none
Patch to see if anything breaks	none
Patch to see if anything breaks	none
Patch to see if anything breaks	none
Import umbrella framework headers	sam: review+
Updated version for when macOS 10.12 is no longer supported	none

mitz

Reported 2018-05-26 15:17:46 PDT

Import umbrella frameworks’ umbrella headers and link against the umbrella frameworks rather than adding the umbrellas’ Frameworks directory to the frameworks search paths and importing subumbrellas directly.

Attachments
Patch to see if anything breaks (23.41 KB, patch) 2018-05-26 16:06 PDT, mitz	no flags	Details Formatted Diff Diff
Patch to see if anything breaks (24.00 KB, patch) 2018-05-26 16:56 PDT, mitz	no flags	Details Formatted Diff Diff
Patch to see if anything breaks (24.43 KB, patch) 2018-05-27 16:21 PDT, mitz	no flags	Details Formatted Diff Diff
Patch to see if anything breaks (25.08 KB, patch) 2018-05-27 17:09 PDT, mitz	no flags	Details Formatted Diff Diff
Import umbrella framework headers (30.99 KB, patch) 2018-05-27 17:47 PDT, mitz	sam: review+	Details Formatted Diff Diff
Updated version for when macOS 10.12 is no longer supported (28.17 KB, patch) 2018-12-22 15:17 PST, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2018-05-26 16:06:40 PDT

Created attachment 341411 [details] Patch to see if anything breaks

mitz

Comment 2 2018-05-26 16:56:22 PDT

Created attachment 341412 [details] Patch to see if anything breaks

mitz

Comment 3 2018-05-27 16:21:56 PDT

Created attachment 341435 [details] Patch to see if anything breaks

mitz

Comment 4 2018-05-27 17:09:56 PDT

Created attachment 341437 [details] Patch to see if anything breaks

mitz

Comment 5 2018-05-27 17:47:05 PDT

Created attachment 341439 [details] Import umbrella framework headers

mitz

Comment 6 2018-05-27 21:18:21 PDT

Committed <https://trac.webkit.org/r232235> with additional changes for the USE(APPLE_INTERNAL_SDK) build.

Radar WebKit Bug Importer

Comment 7 2018-05-27 21:19:18 PDT

<rdar://problem/40591038>

mitz

Comment 8 2018-05-27 21:32:27 PDT

Tried to fix the 32-bit USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232237>.

mitz

Comment 9 2018-05-27 22:05:06 PDT

Tried to fix the pre-High Sierra USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232238>.

mitz

Comment 10 2018-05-27 22:27:16 PDT

ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to undo all the changes for now and perhaps attempt this again when Sierra doesn’t need to be supported.

mitz

Comment 11 2018-05-27 22:32:16 PDT

(In reply to mitz from comment #10) > ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to > undo all the changes for now and perhaps attempt this again when Sierra > doesn’t need to be supported. Reverted everything in <https://trac.webkit.org/r232239>.

mitz

Comment 12 2018-12-22 15:17:16 PST

Created attachment 358025 [details] Updated version for when macOS 10.12 is no longer supported

WebKit Commit Bot

Comment 13 2019-01-12 12:36:14 PST

Comment on attachment 358025 [details] Updated version for when macOS 10.12 is no longer supported Clearing flags on attachment: 358025 Committed r239901: <https://trac.webkit.org/changeset/239901>

WebKit Commit Bot

Comment 14 2019-01-12 12:36:16 PST

All reviewed patches have been landed. Closing bug.

mitz

Comment 15 2019-01-13 15:14:15 PST

(In reply to WebKit Commit Bot from comment #13) > Comment on attachment 358025 [details] > Updated version for when macOS 10.12 is no longer supported > > Clearing flags on attachment: 358025 > > Committed r239901: <https://trac.webkit.org/changeset/239901> Tried to fix USE(APPLE_INTERNAL_SDK) builds in <https://trac.webkit.org/r239909>.

mitz

Comment 16 2019-01-13 15:19:38 PST

(In reply to mitz from comment #15) > (In reply to WebKit Commit Bot from comment #13) > > Comment on attachment 358025 [details] > > Updated version for when macOS 10.12 is no longer supported > > > > Clearing flags on attachment: 358025 > > > > Committed r239901: <https://trac.webkit.org/changeset/239901> > > Tried to fix USE(APPLE_INTERNAL_SDK) builds in > <https://trac.webkit.org/r239909>. …and in <https://trac.webkit.org/r239910>.

WebKit Commit Bot

Comment 17 2019-01-14 14:12:43 PST

Re-opened since this is blocked by bug 193407

mitz

Comment 18 2019-01-20 10:03:15 PST

Committed <https://trac.webkit.org/r240211>.

Note You need to log in before you can comment on or make changes to this bug.