Bug 186016

Summary: [Cocoa] Avoid importing directly from subumbrella frameworks
Product: WebKit Reporter: mitz
Component: WebKit Misc.Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 193407    
Bug Blocks:    
Attachments:
Description Flags
Patch to see if anything breaks
none
Patch to see if anything breaks
none
Patch to see if anything breaks
none
Patch to see if anything breaks
none
Import umbrella framework headers
sam: review+
Updated version for when macOS 10.12 is no longer supported none

Description mitz 2018-05-26 15:17:46 PDT 
Import umbrella frameworks’ umbrella headers and link against the umbrella frameworks rather than adding the umbrellas’ Frameworks directory to the frameworks search paths and importing subumbrellas directly.
Comment 1 mitz 2018-05-26 16:06:40 PDT 
Created attachment 341411 [details]
Patch to see if anything breaks
Comment 2 mitz 2018-05-26 16:56:22 PDT 
Created attachment 341412 [details]
Patch to see if anything breaks
Comment 3 mitz 2018-05-27 16:21:56 PDT 
Created attachment 341435 [details]
Patch to see if anything breaks
Comment 4 mitz 2018-05-27 17:09:56 PDT 
Created attachment 341437 [details]
Patch to see if anything breaks
Comment 5 mitz 2018-05-27 17:47:05 PDT 
Created attachment 341439 [details]
Import umbrella framework headers
Comment 6 mitz 2018-05-27 21:18:21 PDT 
Committed <https://trac.webkit.org/r232235> with additional changes for the USE(APPLE_INTERNAL_SDK) build.
Comment 7 Radar WebKit Bug Importer 2018-05-27 21:19:18 PDT 
<rdar://problem/40591038>
Comment 8 mitz 2018-05-27 21:32:27 PDT 
Tried to fix the 32-bit USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232237>.
Comment 9 mitz 2018-05-27 22:05:06 PDT 
Tried to fix the pre-High Sierra USE(APPLE_INTERNAL_SDK) build in <https://trac.webkit.org/r232238>.
Comment 10 mitz 2018-05-27 22:27:16 PDT 
ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to undo all the changes for now and perhaps attempt this again when Sierra doesn’t need to be supported.
Comment 11 mitz 2018-05-27 22:32:16 PDT 
(In reply to mitz from comment #10)
> ApplicationServicesPriv.h is wreaking havoc in Sierra builds. I am going to
> undo all the changes for now and perhaps attempt this again when Sierra
> doesn’t need to be supported.

Reverted everything in <https://trac.webkit.org/r232239>.
Comment 12 mitz 2018-12-22 15:17:16 PST 
Created attachment 358025 [details]
Updated version for when macOS 10.12 is no longer supported
Comment 13 WebKit Commit Bot 2019-01-12 12:36:14 PST 
Comment on attachment 358025 [details]
Updated version for when macOS 10.12 is no longer supported

Clearing flags on attachment: 358025

Committed r239901: <https://trac.webkit.org/changeset/239901>
Comment 14 WebKit Commit Bot 2019-01-12 12:36:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 mitz 2019-01-13 15:14:15 PST 
(In reply to WebKit Commit Bot from comment #13)
> Comment on attachment 358025 [details]
> Updated version for when macOS 10.12 is no longer supported
> 
> Clearing flags on attachment: 358025
> 
> Committed r239901: <https://trac.webkit.org/changeset/239901>

Tried to fix USE(APPLE_INTERNAL_SDK) builds in <https://trac.webkit.org/r239909>.
Comment 16 mitz 2019-01-13 15:19:38 PST 
(In reply to mitz from comment #15)
> (In reply to WebKit Commit Bot from comment #13)
> > Comment on attachment 358025 [details]
> > Updated version for when macOS 10.12 is no longer supported
> > 
> > Clearing flags on attachment: 358025
> > 
> > Committed r239901: <https://trac.webkit.org/changeset/239901>
> 
> Tried to fix USE(APPLE_INTERNAL_SDK) builds in
> <https://trac.webkit.org/r239909>.

…and in <https://trac.webkit.org/r239910>.
Comment 17 WebKit Commit Bot 2019-01-14 14:12:43 PST 
Re-opened since this is blocked by bug 193407
Comment 18 mitz 2019-01-20 10:03:15 PST 
Committed <https://trac.webkit.org/r240211>.