Bug 185994

Summary:

[mac Debug wk2] Layout Test fast/text/user-installed-fonts/shadow-family.html and fast/text/user-installed-fonts/shadow-postscript-family.html are flaky

Product:

WebKit

Reporter:

Dawei Fenton (:realdawei) <realdawei>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

REOPENED

Severity:

Normal

CC:

ap, commit-queue, lforschler, mmaxfield, ryanhaddad, sroberts, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Update TestExpectations	none
Update TestExpectations	none

Dawei Fenton (:realdawei)

Reported 2018-05-25 14:09:24 PDT

The following layout test is flaky on mac Sierra Debug WK2 fast/text/user-installed-fonts/shadow-family.html Probable Cause: Unknown, it started on 5/3/2018 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ftext%2Fuser-installed-fonts%2Fshadow-family.html

Attachments
Patch (1.48 KB, patch) 2018-05-25 14:53 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Patch (1.63 KB, patch) 2018-05-25 15:52 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Patch (1.64 KB, patch) 2018-05-25 16:19 PDT, Dawei Fenton (:realdawei)	no flags	Details Formatted Diff Diff
Update TestExpectations (1.53 KB, patch) 2019-02-11 09:33 PST, Shawn Roberts	no flags	Details Formatted Diff Diff
Update TestExpectations (1.71 KB, patch) 2019-02-11 16:35 PST, Shawn Roberts	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dawei Fenton (:realdawei)

Comment 1 2018-05-25 14:53:56 PDT

Created attachment 341330 [details] Patch

Dawei Fenton (:realdawei)

Comment 2 2018-05-25 15:48:52 PDT

Actually both fast/text/user-installed-fonts/shadow-family.html and fast/text/user-installed-fonts/shadow-postscript-family.html are flaky on mac Debug Wk2. They yield the same images diff results and so are likely related. https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r232190%20(6600)/results.html

Dawei Fenton (:realdawei)

Comment 3 2018-05-25 15:52:05 PDT

Created attachment 341340 [details] Patch

Dawei Fenton (:realdawei)

Comment 4 2018-05-25 16:19:13 PDT

Created attachment 341347 [details] Patch

Ryan Haddad

Comment 5 2018-05-25 16:35:32 PDT

Marked tests as flaky in https://trac.webkit.org/r232213

Alexey Proskuryakov

Comment 6 2018-05-26 18:53:08 PDT

We get a black rectangle as expected image, and a large letter as actual.

Radar WebKit Bug Importer

Comment 7 2018-05-26 18:53:26 PDT

<rdar://problem/40582929>

Myles C. Maxfield

Comment 8 2018-06-26 00:41:19 PDT

Both of these tests install a user-installed font with the same name as a preinstalled font, and test that the user-installed font gets used when content asks for that (shared) name. I assumed this was well-defined, but it is totally possible that this isn't well-defined. Failing either of these two tests is not indicative of a privacy leak.

Shawn Roberts

Comment 9 2019-02-11 09:32:12 PST

Test is now flaky in Mojave Release WK2.

Shawn Roberts

Comment 10 2019-02-11 09:32:33 PST

Updating test expectations for Mac WK2

Shawn Roberts

Comment 11 2019-02-11 09:33:48 PST

Created attachment 361685 [details] Update TestExpectations

WebKit Commit Bot

Comment 12 2019-02-11 09:48:43 PST

Comment on attachment 361685 [details] Update TestExpectations Rejecting attachment 361685 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 361685, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/11110699

Shawn Roberts

Comment 13 2019-02-11 16:35:40 PST

Created attachment 361729 [details] Update TestExpectations

WebKit Commit Bot

Comment 14 2019-02-11 17:16:24 PST

Comment on attachment 361729 [details] Update TestExpectations Clearing flags on attachment: 361729 Committed r241286: <https://trac.webkit.org/changeset/241286>

WebKit Commit Bot

Comment 15 2019-02-11 17:16:25 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 16 2019-02-11 17:17:24 PST

(In reply to WebKit Commit Bot from comment #14) > Comment on attachment 361729 [details] > Update TestExpectations > > Clearing flags on attachment: 361729 > > Committed r241286: <https://trac.webkit.org/changeset/241286> Reopening since this change only updated test expectations.

Note You need to log in before you can comment on or make changes to this bug.