Bug 185989

Summary:

JavaScriptCore: Disable 32-bit JIT on Windows

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, mark.lam, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

186061, 186153, 186477

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Updated Patch	none
Updated Patch	mark.lam: review+, msaboff: commit-queue-
Archive of layout-test-results from ews201 for win-future	none

Michael Saboff

Reported 2018-05-25 12:58:31 PDT

This code is not being maintained. For some 32 bit apps, the JIT doesn't provide a performance benefit. Disabling the JIT will also save memory.

Attachments
Patch (1.09 KB, patch) 2018-05-25 13:03 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
Updated Patch (5.26 KB, patch) 2018-06-01 16:31 PDT, Michael Saboff	no flags	Details Formatted Diff Diff
Updated Patch (5.29 KB, patch) 2018-06-01 16:35 PDT, Michael Saboff	mark.lam: review+ msaboff: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews201 for win-future (12.80 MB, application/zip) 2018-06-01 20:24 PDT, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2018-05-25 12:58:50 PDT

<rdar://problem/40343776>

Michael Saboff

Comment 2 2018-05-25 13:03:45 PDT

Created attachment 341312 [details] Patch

WebKit Commit Bot

Comment 3 2018-05-25 16:26:48 PDT

Comment on attachment 341312 [details] Patch Clearing flags on attachment: 341312 Committed r232212: <https://trac.webkit.org/changeset/232212>

WebKit Commit Bot

Comment 4 2018-05-25 16:26:50 PDT

All reviewed patches have been landed. Closing bug.

Michael Saboff

Comment 5 2018-05-29 14:47:26 PDT

This change broke the Win32 build.

Michael Saboff

Comment 6 2018-06-01 16:31:03 PDT

Created attachment 341801 [details] Updated Patch

EWS Watchlist

Comment 7 2018-06-01 16:33:01 PDT

Attachment 341801 [details] did not pass style-queue: ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Saboff

Comment 8 2018-06-01 16:35:53 PDT

Created attachment 341802 [details] Updated Patch

Mark Lam

Comment 9 2018-06-01 16:46:01 PDT

Comment on attachment 341802 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341802&action=review r=me if the EWS bots are happy. > Source/JavaScriptCore/ChangeLog:8 > + Made various minor fixes. I think you should mention that these fixes are so that the CLOOP can work when COMPUTED_GOTOs is not supported. > Source/JavaScriptCore/ChangeLog:13 > + * llint/LowLevelInterpreter.cpp: Changed the definition of OFFLINE_ASM_GLOBAL_LABEL to not > + have a case label these aren't opcodes. Did you mean "... case label because these aren't opcodes"?

EWS Watchlist

Comment 10 2018-06-01 20:24:26 PDT

Comment on attachment 341802 [details] Updated Patch Attachment 341802 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7938086 New failing tests: js/slow-stress/emscripten-memops.html workers/bomb.html js/dom/line-column-numbers.html js/regexp-zero-length-alternatives.html fast/workers/worker-document-leak.html accessibility/accessibility-node-memory-management.html storage/indexeddb/modern/leak-1.html

EWS Watchlist

Comment 11 2018-06-01 20:24:37 PDT

Created attachment 341822 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Michael Saboff

Comment 12 2018-06-10 22:33:26 PDT

(In reply to Build Bot from comment #10) > Comment on attachment 341802 [details] > Updated Patch > > Attachment 341802 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/7938086 > > New failing tests: ... > js/regexp-zero-length-alternatives.html ... The failure of js/regexp-zero-length-alternatives.html is being tracked in https://bugs.webkit.org/show_bug.cgi?id=186477

Michael Saboff

Comment 13 2018-06-11 09:39:51 PDT

Committed r232719: <https://trac.webkit.org/changeset/232719>

Note You need to log in before you can comment on or make changes to this bug.