Bug 185983

Summary: [Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, beidson, commit-queue, sam, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andy Estes 2018-05-25 09:25:21 PDT
[Wi-Fi Assertions] Track whether WiFiAssertionHolder should actually hold a Wi-Fi assertion
Comment 1 Andy Estes 2018-05-25 09:28:02 PDT
Created attachment 341293 [details]
Patch
Comment 2 Andy Estes 2018-05-25 09:28:16 PDT
rdar://problem/40205486
Comment 3 Tim Horton 2018-05-28 23:26:21 PDT
Comment on attachment 341293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341293&action=review

> Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.mm:48
> +    holdWiFiAssertion(*this);

Seems odd to call hold and release if shouldHold is false
Comment 4 WebKit Commit Bot 2018-05-29 17:47:06 PDT
Comment on attachment 341293 [details]
Patch

Clearing flags on attachment: 341293

Committed r232283: <https://trac.webkit.org/changeset/232283>
Comment 5 WebKit Commit Bot 2018-05-29 17:47:07 PDT
All reviewed patches have been landed.  Closing bug.