Bug 185966

Summary: [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, dbates, ews-watchlist, ggaren, japhet, koivisto, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2018-05-24 16:42:37 PDT
Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text: Sample Count, Samples %, CPU %, Symbol 33, 0.3%, 0.2%, void IPC::handleMessage<Messages::WebResourceLoader::DidReceiveResponse, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)) (in WebKit) 33, 0.3%, 0.2%, WebKit::WebResourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, bool) (in WebKit) 32, 0.3%, 0.2%, WebCore::SubresourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, WTF::CompletionHandler<void ()>&&) (in WebCore) 26, 0.2%, 0.1%, WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&) (in WebCore) 26, 0.2%, 0.1%, std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) (in libc++.1.dylib) 26, 0.2%, 0.1%, void std::__1::__call_once_proxy<std::__1::tuple<WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&)::$_2&&> >(void*) (in WebCore) 26, 0.2%, 0.1%, WebCore::QLPreviewGetSupportedMIMETypesSet() (in WebCore) 26, 0.2%, 0.1%, WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore) 26, 0.2%, 0.1%, dispatch_once_f$VARIANT$mp (in libdispatch.dylib) 26, 0.2%, 0.1%, _dispatch_client_callout (in libdispatch.dylib) 26, 0.2%, 0.1%, invocation function for block in WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore) 26, 0.2%, 0.1%, dispatch_once_f$VARIANT$mp (in libdispatch.dylib) 26, 0.2%, 0.1%, _dispatch_client_callout (in libdispatch.dylib) 26, 0.2%, 0.1%, invocation function for block in WebCore::QuickLookLibrary(bool) (in WebCore) 26, 0.2%, 0.1%, dlopen (in libdyld.dylib) 26, 0.2%, 0.1%, dlopen_internal (in dyld)
Attachments
Patch (1.58 KB, patch)
2018-05-24 16:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-05-24 16:44:56 PDT
Created attachment 341233 [details] Patch
Geoffrey Garen
Comment 2 2018-05-24 17:18:06 PDT
Comment on attachment 341233 [details] Patch r=me
WebKit Commit Bot
Comment 3 2018-05-24 18:58:20 PDT
Comment on attachment 341233 [details] Patch Clearing flags on attachment: 341233 Committed r232179: <https://trac.webkit.org/changeset/232179>
WebKit Commit Bot
Comment 4 2018-05-24 18:58:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-24 18:59:21 PDT
<rdar://problem/40542935>
Note You need to log in before you can comment on or make changes to this bug.