Bug 185955

Summary: REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179747    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2018-05-24 12:46:54 PDT
In Bug 179747 I removed access to the MediaAccessibility mach port, as well as read/write access to various preferences associated with that process, as it was no longer needed by modern WebKit media routines.

Detailed testing reveals that read access is still needed to these preferences to properly handle custom caption styles.

This patch re-enables access to the media accessibility preferences.
Comment 1 Brent Fulgham 2018-05-24 12:48:17 PDT
<rdar://problem/40339278>
Comment 2 Brent Fulgham 2018-05-24 12:52:09 PDT
Created attachment 341217 [details]
Patch
Comment 3 WebKit Commit Bot 2018-05-24 13:33:23 PDT
Comment on attachment 341217 [details]
Patch

Clearing flags on attachment: 341217

Committed r232162: <https://trac.webkit.org/changeset/232162>
Comment 4 WebKit Commit Bot 2018-05-24 13:33:24 PDT
All reviewed patches have been landed.  Closing bug.