Bug 185955

Summary: REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179747    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2018-05-24 12:46:54 PDT
In Bug 179747 I removed access to the MediaAccessibility mach port, as well as read/write access to various preferences associated with that process, as it was no longer needed by modern WebKit media routines. Detailed testing reveals that read access is still needed to these preferences to properly handle custom caption styles. This patch re-enables access to the media accessibility preferences.
Attachments
Patch (1.79 KB, patch)
2018-05-24 12:52 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-05-24 12:48:17 PDT
<rdar://problem/40339278>
Brent Fulgham
Comment 2 2018-05-24 12:52:09 PDT
Created attachment 341217 [details] Patch
WebKit Commit Bot
Comment 3 2018-05-24 13:33:23 PDT
Comment on attachment 341217 [details] Patch Clearing flags on attachment: 341217 Committed r232162: <https://trac.webkit.org/changeset/232162>
WebKit Commit Bot
Comment 4 2018-05-24 13:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.