Summary: | Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren, krollin, rniwa, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2018-05-24 10:08:30 PDT
Sample Count, Samples %, CPU %, Symbol 17, 0.2%, 0.1%, WebKit::InitializeWebKit2() (in WebKit) 17, 0.2%, 0.1%, std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) (in libc++.1.dylib) 17, 0.2%, 0.1%, WebKit::runInitializationCode(void*) (in WebKit) 11, 0.1%, 0.1%, WebCore::initializeLogChannelsIfNecessary(std::optional<WTF::String>) (in WebCore) 6, 0.1%, 0.0%, WebCore::logLevelString() (in WebCore) 5, 0.1%, 0.0%, +[NSUserDefaults(NSUserDefaults) standardUserDefaults] (in Foundation) 5, 0.1%, 0.0%, -[NSUserDefaults(NSUserDefaults) init] (in Foundation) 5, 0.1%, 0.0%, +[NSLocale currentLocale] (in CoreFoundation) 1, 0.0%, 0.0%, -[NSUserDefaults(NSUserDefaults) stringForKey:] (in Foundation) 5, 0.1%, 0.0%, WTFInitializeLogChannelStatesFromString (in JavaScriptCore) 5, 0.1%, 0.0%, os_log_create (in libsystem_trace.dylib) Created attachment 341204 [details]
Patch
Comment on attachment 341204 [details]
Patch
r=me
Comment on attachment 341204 [details] Patch Clearing flags on attachment: 341204 Committed r232158: <https://trac.webkit.org/changeset/232158> All reviewed patches have been landed. Closing bug. |