Bug 185945

Summary: [Baseline] Remove a hack for DCE removal of NewFunction
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Description Yusuke Suzuki 2018-05-24 06:49:15 PDT 
[Baseline] Remove a hack for DCE removal of NewFunction
Comment 1 Yusuke Suzuki 2018-05-24 08:12:27 PDT 
Created attachment 341189 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-24 20:17:19 PDT 
Created attachment 341244 [details]
Patch
Comment 3 Saam Barati 2018-05-24 21:25:43 PDT 
Comment on attachment 341244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341244&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6338
> +            addToGraph(Phantom, scope);

Put this after the set?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6375
> +            set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(op, OpInfo(frozen), scope));

ditto
Comment 4 Yusuke Suzuki 2018-05-24 21:27:41 PDT 
Comment on attachment 341244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341244&action=review

Thank you!

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6338
>> +            addToGraph(Phantom, scope);
> 
> Put this after the set?

Fixed.

>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6375
>> +            set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(op, OpInfo(frozen), scope));
> 
> ditto

Fixed.
Comment 5 Yusuke Suzuki 2018-05-24 21:29:19 PDT 
Committed r232182: <https://trac.webkit.org/changeset/232182>
Comment 6 Radar WebKit Bug Importer 2018-05-24 21:30:22 PDT 
<rdar://problem/40545750>