RESOLVED FIXED185945
[Baseline] Remove a hack for DCE removal of NewFunction 
https://bugs.webkit.org/show_bug.cgi?id=185945
Summary [Baseline] Remove a hack for DCE removal of NewFunction
Yusuke Suzuki
Reported 2018-05-24 06:49:15 PDT
[Baseline] Remove a hack for DCE removal of NewFunction
Attachments
Patch (6.39 KB, patch)
2018-05-24 08:12 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (6.41 KB, patch)
2018-05-24 20:17 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-24 08:12:27 PDT
Created attachment 341189 [details] Patch
Yusuke Suzuki
Comment 2 2018-05-24 20:17:19 PDT
Created attachment 341244 [details] Patch
Saam Barati
Comment 3 2018-05-24 21:25:43 PDT
Comment on attachment 341244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341244&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6338 > + addToGraph(Phantom, scope); Put this after the set? > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6375 > + set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(op, OpInfo(frozen), scope)); ditto
Yusuke Suzuki
Comment 4 2018-05-24 21:27:41 PDT
Comment on attachment 341244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341244&action=review Thank you! >> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6338 >> + addToGraph(Phantom, scope); > > Put this after the set? Fixed. >> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6375 >> + set(VirtualRegister(currentInstruction[1].u.operand), addToGraph(op, OpInfo(frozen), scope)); > > ditto Fixed.
Yusuke Suzuki
Comment 5 2018-05-24 21:29:19 PDT
Committed r232182: <https://trac.webkit.org/changeset/232182>
Radar WebKit Bug Importer
Comment 6 2018-05-24 21:30:22 PDT
<rdar://problem/40545750>
Note You need to log in before you can comment on or make changes to this bug.