Bug 185944

Summary: [MIPS] Fix build on MIPS32r1
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, ggaren, jiewen_tan, keith_miller, loic.yhuel, mark.lam, msaboff, olivier.blin, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dominik Inführ
Reported 2018-05-24 06:10:21 PDT
[MIPS] Fix build on MIPS32r1
Attachments
Patch (3.42 KB, patch)
2018-05-24 06:15 PDT, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-05-24 06:15:24 PDT
Created attachment 341185 [details] Patch
Loïc Yhuel
Comment 2 2018-05-24 08:40:06 PDT
This looks ok, and builds fine. Here are the different cases I can think of : - -march=mips32 -mfp32 : mtc1/mfc1, OK - -march=mips32 -mfpxx (so __mips_isa_rev == 1, __mips_fpr == 0) : "as" would fail with "Error: float register should be even, was xx" (the only way would be to an intermediate memory transfer). Nothing changes here, so I think no one uses this configuration so it's fine if WebKit doesn't support it. - -march=mips32r2 -mfp32 : mfhc1 and mthc1 are used even if not necessary, but this isn't an issue - -march=mips32r2 -mfpxx : mfhc1 and mthc1, OK - -mfp64 : gcc already ensures mfhc1 and mthc1 are available
Olivier Blin
Comment 3 2018-05-25 07:41:57 PDT
I confirm it builds fine on a MIPS32r1 target, and jsc runs correctly too.
Yusuke Suzuki
Comment 4 2018-05-30 06:46:31 PDT
Comment on attachment 341185 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-05-30 07:13:27 PDT
Comment on attachment 341185 [details] Patch Clearing flags on attachment: 341185 Committed r232290: <https://trac.webkit.org/changeset/232290>
WebKit Commit Bot
Comment 6 2018-05-30 07:13:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-05-30 07:14:24 PDT
<rdar://problem/40649432>
Note You need to log in before you can comment on or make changes to this bug.