Bug 185925

Summary: OSBuildFetcher should respect maxRevision while finding OS builds to report.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Description dewei_zhu 2018-05-23 16:26:38 PDT 
OSBuildFetcher should respect maxRevision while finding OS builds to report.
Comment 1 dewei_zhu 2018-05-23 16:59:23 PDT 
Created attachment 341148 [details]
Patch
Comment 2 Ryosuke Niwa 2018-05-23 17:08:44 PDT 
Comment on attachment 341148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
> -                .filter((commit) => commit['order'] > minOrder);
> +                .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);

It seems that minOrder & maxOrder should be inclusive.
Comment 3 dewei_zhu 2018-05-23 17:11:02 PDT 
Comment on attachment 341148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341148&action=review

>> Websites/perf.webkit.org/tools/js/os-build-fetcher.js:101
>> +                .filter((commit) => commit['order'] > minOrder && commit['order'] < maxOrder);
> 
> It seems that minOrder & maxOrder should be inclusive.

For minOrder, it should be exclusive as it is from 'last-reported' api and we don't want to report 'last-reported' again. For maxOrder, it could be both either way.