Bug 185914

Summary: Speed up JetStream/base64
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch
msaboff: review+
patch for landing
none
patch for landing none

Filip Pizlo
Reported 2018-05-23 07:40:33 PDT
While profiling base64, I found that: - It really wanted allocation paths to be inline in C++ code. - Rope string resolution was spending a lot of time calling Vector<>::append because it wasn't inlined.
Attachments
the patch (20.26 KB, patch)
2018-05-23 07:42 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (21.94 KB, patch)
2018-05-23 12:27 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
patch for landing (22.93 KB, patch)
2018-05-23 13:44 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
patch for landing (23.42 KB, patch)
2018-05-23 14:05 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-05-23 07:42:03 PDT
Created attachment 341091 [details] the patch
EWS Watchlist
Comment 2 2018-05-23 07:45:09 PDT
Attachment 341091 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2018-05-23 12:27:43 PDT
Created attachment 341116 [details] the patch
Michael Saboff
Comment 4 2018-05-23 12:29:40 PDT
Comment on attachment 341116 [details] the patch r=me Nice!
EWS Watchlist
Comment 5 2018-05-23 12:30:33 PDT
Attachment 341116 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 6 2018-05-23 13:44:42 PDT
Created attachment 341125 [details] patch for landing
EWS Watchlist
Comment 7 2018-05-23 13:47:01 PDT
Attachment 341125 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2018-05-23 14:05:35 PDT
Created attachment 341127 [details] patch for landing
EWS Watchlist
Comment 9 2018-05-23 14:07:15 PDT
Attachment 341127 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCellInlines.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 10 2018-05-23 15:34:34 PDT
Landed in https://trac.webkit.org/changeset/232132/webkit
Radar WebKit Bug Importer
Comment 11 2018-05-23 15:46:19 PDT
<rdar://problem/40501797>
Note You need to log in before you can comment on or make changes to this bug.