Bug 185898

Summary: [LFC] Move sizing/positioning logic to helper classes
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2018-05-22 19:21:55 PDT
with static functions.
Attachments
Patch (85.62 KB, patch)
2018-05-22 20:24 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (90.02 KB, patch)
2018-05-23 09:17 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-05-22 20:24:55 PDT
Created attachment 341064 [details] Patch
alan
Comment 2 2018-05-22 20:37:40 PDT
Not sure about the class names though. Suggestions are welcome!
Antti Koivisto
Comment 3 2018-05-23 07:21:35 PDT
Comment on attachment 341064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341064&action=review > Source/WebCore/layout/FormattingContext.cpp:66 > + computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox); Maybe FormattingContextGeometry could be an inner class of FormattingContext (FormattingContext::Geometry)? This way you could just write Geometry::outOfFlowReplacedPosition(...) here.
alan
Comment 4 2018-05-23 09:17:16 PDT
Created attachment 341096 [details] Patch
alan
Comment 5 2018-05-23 09:17:34 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 341064 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341064&action=review > > > Source/WebCore/layout/FormattingContext.cpp:66 > > + computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox); > > Maybe FormattingContextGeometry could be an inner class of FormattingContext > (FormattingContext::Geometry)? > > This way you could just write Geometry::outOfFlowReplacedPosition(...) here. Good point!
WebKit Commit Bot
Comment 6 2018-05-23 09:56:18 PDT
Comment on attachment 341096 [details] Patch Clearing flags on attachment: 341096 Committed r232114: <https://trac.webkit.org/changeset/232114>
WebKit Commit Bot
Comment 7 2018-05-23 09:56:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-05-23 09:57:22 PDT
<rdar://problem/40488646>
Note You need to log in before you can comment on or make changes to this bug.