Summary: | [LFC] Move sizing/positioning logic to helper classes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2018-05-22 19:21:55 PDT
Created attachment 341064 [details]
Patch
Not sure about the class names though. Suggestions are welcome! Comment on attachment 341064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341064&action=review > Source/WebCore/layout/FormattingContext.cpp:66 > + computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox); Maybe FormattingContextGeometry could be an inner class of FormattingContext (FormattingContext::Geometry)? This way you could just write Geometry::outOfFlowReplacedPosition(...) here. Created attachment 341096 [details]
Patch
(In reply to Antti Koivisto from comment #3) > Comment on attachment 341064 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341064&action=review > > > Source/WebCore/layout/FormattingContext.cpp:66 > > + computedTopLeft = FormattingContextGeometry::outOfFlowReplacedPosition(layoutContext, layoutBox); > > Maybe FormattingContextGeometry could be an inner class of FormattingContext > (FormattingContext::Geometry)? > > This way you could just write Geometry::outOfFlowReplacedPosition(...) here. Good point! Comment on attachment 341096 [details] Patch Clearing flags on attachment: 341096 Committed r232114: <https://trac.webkit.org/changeset/232114> All reviewed patches have been landed. Closing bug. |