Summary: | Fix build without MathML | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, fred.wang, koivisto, mcatanzaro, simon.fraser, webkit-bug-importer, zalan, zan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Olivier Blin
2018-05-22 05:42:24 PDT
Created attachment 340976 [details]
Patch
You may want to know if it is still worth maintaining this MathML build flag. On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a library of 27,063,644 bytes, that's about 1% of the size. Comment on attachment 340976 [details]
Patch
Sigh, I think it's OK even without exposing the MATHML build flag for WPE, because none of the code is platform-specific.
(In reply to Olivier Blin from comment #2) > You may want to know if it is still worth maintaining this MathML build flag. > > On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a > library of 27,063,644 bytes, that's about 1% of the size. And yes, if you didn't have this analysis to prove it's significant, we would have probably started to talk about that. Comment on attachment 340976 [details] Patch Clearing flags on attachment: 340976 Committed r232064: <https://trac.webkit.org/changeset/232064> All reviewed patches have been landed. Closing bug. |