Bug 185826

Summary:

Add a diskCacheSizeOverride accessor function on WKContextConfigurationRef

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

WebKit API

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, sihui_liu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sihui Liu 2018-05-21 11:48:39 PDT

Required for <rdar://problem/39432656>.

Comment 1 Sihui Liu 2018-05-21 11:49:21 PDT

<rdar://problem/39732113>

Comment 2 Sihui Liu 2018-05-21 11:59:05 PDT

Created attachment 340868 [details]
Patch

Comment 3 Chris Dumez 2018-05-21 12:29:14 PDT

Comment on attachment 340868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340868&action=review

> Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83
> +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration);

Is there an equivalent Cocoa API / SPI already? We are not supposed to add any new C API without a Cocoa equivalent.

Comment 4 Sihui Liu 2018-05-21 13:28:58 PDT

(In reply to Chris Dumez from comment #3)
> Comment on attachment 340868 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340868&action=review
> 
> > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83
> > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration);
> 
> Is there an equivalent Cocoa API / SPI already? We are not supposed to add
> any new C API without a Cocoa equivalent.

There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h.

Comment 5 Chris Dumez 2018-05-21 13:30:57 PDT

(In reply to Sihui Liu from comment #4)
> (In reply to Chris Dumez from comment #3)
> > Comment on attachment 340868 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=340868&action=review
> > 
> > > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83
> > > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration);
> > 
> > Is there an equivalent Cocoa API / SPI already? We are not supposed to add
> > any new C API without a Cocoa equivalent.
> 
> There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h.

Great, thanks.

Comment 6 WebKit Commit Bot 2018-05-21 13:57:57 PDT

Comment on attachment 340868 [details]
Patch

Clearing flags on attachment: 340868

Committed r232025: <https://trac.webkit.org/changeset/232025>

Comment 7 WebKit Commit Bot 2018-05-21 13:57:58 PDT

All reviewed patches have been landed.  Closing bug.