Bug 185824

Summary: [WPE][WebDriver] add ICU include dirs
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bburg, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Olivier Blin
Reported 2018-05-21 10:30:35 PDT
WebDriver does not build in the WPE port when ICU headers are in a non-default directory.
Attachments
Patch (1.19 KB, patch)
2018-05-21 10:32 PDT, Olivier Blin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2018-05-21 10:32:06 PDT
Created attachment 340861 [details] Patch
Olivier Blin
Comment 2 2018-05-21 10:34:23 PDT
Comment on attachment 340861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review > Source/WebDriver/PlatformWPE.cmake:5 > + "${ICU_INCLUDE_DIRS}" Is this the best place to put this since ICU is common to all ports? Shouldn't this be inherited from WTF?
Konstantin Tokarev
Comment 3 2018-05-21 10:39:05 PDT
Comment on attachment 340861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review >> Source/WebDriver/PlatformWPE.cmake:5 >> + "${ICU_INCLUDE_DIRS}" > > Is this the best place to put this since ICU is common to all ports? > Shouldn't this be inherited from WTF? It was once working like this, but is not the case since https://bugs.webkit.org/show_bug.cgi?id=181656
WebKit Commit Bot
Comment 4 2018-05-21 11:17:42 PDT
Comment on attachment 340861 [details] Patch Clearing flags on attachment: 340861 Committed r232022: <https://trac.webkit.org/changeset/232022>
WebKit Commit Bot
Comment 5 2018-05-21 11:17:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-05-21 11:18:18 PDT
<rdar://problem/40422734>
Note You need to log in before you can comment on or make changes to this bug.