| Summary: | [WPE][WebDriver] add ICU include dirs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> | ||||
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, aperez, bburg, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, zan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Olivier Blin
2018-05-21 10:30:35 PDT
Created attachment 340861 [details]
Patch
Comment on attachment 340861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review > Source/WebDriver/PlatformWPE.cmake:5 > + "${ICU_INCLUDE_DIRS}" Is this the best place to put this since ICU is common to all ports? Shouldn't this be inherited from WTF? Comment on attachment 340861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review >> Source/WebDriver/PlatformWPE.cmake:5 >> + "${ICU_INCLUDE_DIRS}" > > Is this the best place to put this since ICU is common to all ports? > Shouldn't this be inherited from WTF? It was once working like this, but is not the case since https://bugs.webkit.org/show_bug.cgi?id=181656 Comment on attachment 340861 [details] Patch Clearing flags on attachment: 340861 Committed r232022: <https://trac.webkit.org/changeset/232022> All reviewed patches have been landed. Closing bug. |