Bug 185813

Summary: [JSC] Remove duplicate methods in JSInterfaceJIT
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
saam: review+
Patch for landing none

Yusuke Suzuki
Reported 2018-05-20 23:00:16 PDT
[JSC] Remove duplicate methods in JSInterfaceJIT
Attachments
Patch (28.90 KB, patch)
2018-05-20 23:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (29.92 KB, patch)
2018-05-21 05:55 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (29.81 KB, patch)
2018-05-21 06:13 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Patch for landing (29.07 KB, patch)
2018-05-21 22:14 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-05-20 23:01:02 PDT
Created attachment 340828 [details] Patch
Yusuke Suzuki
Comment 2 2018-05-21 05:55:57 PDT
Created attachment 340843 [details] Patch
Yusuke Suzuki
Comment 3 2018-05-21 06:13:19 PDT
Created attachment 340846 [details] Patch
Saam Barati
Comment 4 2018-05-21 17:21:34 PDT
Comment on attachment 340846 [details] Patch r=me if 32-bit is working
Yusuke Suzuki
Comment 5 2018-05-21 22:14:46 PDT
Created attachment 340955 [details] Patch for landing
Yusuke Suzuki
Comment 6 2018-05-21 22:16:39 PDT
Comment on attachment 340846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340846&action=review > Source/JavaScriptCore/jit/ThunkGenerators.cpp:382 > + JSInterfaceJIT::Jump exceptionHandler = jit.branchTestPtr(JSInterfaceJIT::NonZero, JSInterfaceJIT::AbsoluteAddress(vm->addressOfException())); Oh, we do not have branchTestPtr(cond, AbsoluteAddress) for 32bit...
Yusuke Suzuki
Comment 7 2018-05-21 22:46:33 PDT
Committed r232048: <https://trac.webkit.org/changeset/232048>
Radar WebKit Bug Importer
Comment 8 2018-05-21 22:47:19 PDT
<rdar://problem/40441671>
Note You need to log in before you can comment on or make changes to this bug.