Bug 185813

Summary: [JSC] Remove duplicate methods in JSInterfaceJIT
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
sbarati: review+
Patch for landing none

Description Yusuke Suzuki 2018-05-20 23:00:16 PDT
[JSC] Remove duplicate methods in JSInterfaceJIT
Comment 1 Yusuke Suzuki 2018-05-20 23:01:02 PDT
Created attachment 340828 [details]
Patch
Comment 2 Yusuke Suzuki 2018-05-21 05:55:57 PDT
Created attachment 340843 [details]
Patch
Comment 3 Yusuke Suzuki 2018-05-21 06:13:19 PDT
Created attachment 340846 [details]
Patch
Comment 4 Saam Barati 2018-05-21 17:21:34 PDT
Comment on attachment 340846 [details]
Patch

r=me if 32-bit is working
Comment 5 Yusuke Suzuki 2018-05-21 22:14:46 PDT
Created attachment 340955 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2018-05-21 22:16:39 PDT
Comment on attachment 340846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340846&action=review

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:382
> +    JSInterfaceJIT::Jump exceptionHandler = jit.branchTestPtr(JSInterfaceJIT::NonZero, JSInterfaceJIT::AbsoluteAddress(vm->addressOfException()));

Oh, we do not have branchTestPtr(cond, AbsoluteAddress) for 32bit...
Comment 7 Yusuke Suzuki 2018-05-21 22:46:33 PDT
Committed r232048: <https://trac.webkit.org/changeset/232048>
Comment 8 Radar WebKit Bug Importer 2018-05-21 22:47:19 PDT
<rdar://problem/40441671>