| Summary: | [JSC] Use branchIfString/branchIfNotString instead of structure checkings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2018-05-20 21:32:07 PDT
Created attachment 340821 [details]
Patch
Comment on attachment 340821 [details] Patch Attachment 340821 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7761860 New failing tests: http/tests/preload/onload_event.html Created attachment 340959 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 340821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + it emits less code since we do not need to embed string structure's We would only embed this on 32-bit. Comment on attachment 340821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340821&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + it emits less code since we do not need to embed string structure's > > We would only embed this on 32-bit. Yeah, we emit structure id :) Committed r232105: <https://trac.webkit.org/changeset/232105> |