| Summary: | Handle failure to extend sandbox gracefully | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, realdawei, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2018-05-18 12:11:34 PDT
Created attachment 340729 [details]
Patch
Comment on attachment 340729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340729&action=review Looks great! r=me > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:186 > + UNUSED_PARAM(proxy); You probably don't need UNUSED_PARAM here, since proxy is used below. Comment on attachment 340729 [details] Patch Clearing flags on attachment: 340729 Committed r231979: <https://trac.webkit.org/changeset/231979> All reviewed patches have been landed. Closing bug. The API test added with this change is failing regularly: MediaCaptureSimulateFailedSandbox.Test https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/5462/steps/run-api-tests/logs/stdio /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:139 Value of: "AbortError,Unable to extend sandbox" Expected: [error UTF8String] Which is: "AbortError,Unable to extend sandbox." Reopening to attach new patch. Created attachment 340743 [details]
Fix test results
Comment on attachment 340743 [details] Fix test results Clearing flags on attachment: 340743 Committed r231992: <https://trac.webkit.org/changeset/231992> All reviewed patches have been landed. Closing bug. |