Bug 185776

Summary: build-webkit: Perl "use of uninitialized value $previousContents"
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, basuke, ddkilzer, don.olmstead, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: PC   
OS: Other   
Bug Depends on:    
Bug Blocks: 182575    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-05-18 11:52:16 PDT
When looking at <https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/841/steps/compile-webkit/logs/stdio> I noticed the following Perl warnings: [[ perl ./Tools/Scripts/build-webkit --debug --wincairo ... Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969. Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972. [0/219] Generate bindings (WebCoreBindings) ... ]]
Attachments
Patch (1.61 KB, patch)
2018-05-18 11:57 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-05-18 11:54:56 PDT
These warnings means that the specified file passed to isCachedArgumentfileOutOfDate() is an empty file.
Daniel Bates
Comment 2 2018-05-18 11:57:58 PDT
Created attachment 340722 [details] Patch
Basuke Suzuki
Comment 3 2018-05-18 13:33:17 PDT
Nice. I'm so sad my perl knowledge is so out of date that I cannot judge this fix is correct or not. This may solve an warning issue, that's good. Then it open the next door what makes this file keep being blank though.
Daniel Bates
Comment 4 2018-06-29 19:12:53 PDT
Comment on attachment 340722 [details] Patch Clearing flags on attachment: 340722 Committed r233388: <https://trac.webkit.org/changeset/233388>
Daniel Bates
Comment 5 2018-06-29 19:12:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-29 19:13:15 PDT
<rdar://problem/41663619>
Note You need to log in before you can comment on or make changes to this bug.