Bug 185775

Summary: Convert ProcessPrivilege assertions to regular debug-only assertions
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ddkilzer, ggaren, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 184322    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2018-05-18 11:37:24 PDT
In Bug 184322 I added a number of RELEASE_ASSERT checks that WindowServer-related calls were not being made in the WebContent process. Measurements have shown that these RELEASE_ASSERTs have regressed performance by around 1% on some benchmarks, so we should convert them to normal asserts.
Attachments
Patch (19.36 KB, patch)
2018-05-18 11:41 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-05-18 11:40:27 PDT
<rdar://problem/40372286>
Brent Fulgham
Comment 2 2018-05-18 11:41:53 PDT
Created attachment 340719 [details] Patch
Geoffrey Garen
Comment 3 2018-05-18 12:53:41 PDT
Comment on attachment 340719 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-05-18 13:20:40 PDT
Comment on attachment 340719 [details] Patch Clearing flags on attachment: 340719 Committed r231980: <https://trac.webkit.org/changeset/231980>
WebKit Commit Bot
Comment 5 2018-05-18 13:20:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.