Bug 18576

Summary:

[GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and GDK_KP_Enter

Product:

WebKit

Reporter:

Marco Barisione <marco.barisione>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alp

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent	alp: review+

Description Marco Barisione 2008-04-18 03:37:50 PDT

windowsKeyCodeForKeyEvent (in WebCore/platform/gtk/KeyEventGtk.cpp) handles GDK_Return but not GDK_ISO_Enter and GDK_KP_Enter.

I will write a patch ASAP.

Comment 1 Marco Barisione 2008-04-18 04:20:51 PDT

Created attachment 20663 [details]
Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent

Comment 2 Alp Toker 2008-04-18 20:32:08 PDT

Landed in r32245.

patch had a little trouble with this one so I had to hand-apply.