Bug 185740

Summary: [MSE][GStreamer] Force segment.start = 0 after matroskademux
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, eocanha
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2018-05-17 12:40:34 PDT
This patch ensures that when WebM MSE media segments are appended in an out of order fashion their frames are not discarded by opusparse or any other potential elements downstream in the AppendPipeline that perform segment clipping. This patch fixes the following YTTV 2018 tests: 38. OpusAudioWithOverlap 39. OpusAudioWithSmallGap 40. OpusAudioWithLargeGap 70. VP9VideoWithOverlap 71. VP9VideoWithSmallGap This patch is necessary, but not sufficient for fixing the following YTTV 2018 tests: 36. AppendOpusAudioOutOfOrder 67. AppendVP9VideoOutOfOrder
Attachments
Patch (4.65 KB, patch)
2018-05-17 12:51 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-05-17 12:51:33 PDT
Created attachment 340628 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-05-21 04:11:32 PDT
It looks good. Let's have Quique having last word.
WebKit Commit Bot
Comment 3 2018-05-21 04:52:39 PDT
Comment on attachment 340628 [details] Patch Clearing flags on attachment: 340628 Committed r232014: <https://trac.webkit.org/changeset/232014>
WebKit Commit Bot
Comment 4 2018-05-21 04:52:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.