Bug 185722 – Safari optimized flow should be releasing viewer to prevent memory growth with subsequent launches/closes

• Component: New Bugs
• Status: RESOLVED FIXED

[Dean Jackson]

Safari optimized flow should be releasing viewer to prevent memory growth with subsequent launches/closes

[Dean Jackson]

<rdar://problem/40247351>

[Dean Jackson]

Created attachment 340570 [details]
Patch

[David Kilzer (:ddkilzer)]

Comment on attachment 340570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340570&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:90
> +    WebKit::WeakObjCPtr<_WKPreviewControllerDataSource> weakSelf { self };

FWIW, as of Bug 184789 / r230824, you can start using __weak directly.  Not sure how well that plays with C++ lambdas, though.

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:93
> +        auto strongSelf = weakSelf.get();
> +        if (strongSelf)

Nit: Could use:

        if ((auto strongSelf = weakSelf.get()))

[Dean Jackson]

(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 340570 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340570&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:90
> > +    WebKit::WeakObjCPtr<_WKPreviewControllerDataSource> weakSelf { self };
> 
> FWIW, as of Bug 184789 / r230824, you can start using __weak directly.  Not
> sure how well that plays with C++ lambdas, though.

This can just be a regular block, so __weak would be fine. However, I didn't see any other uses of __weak, so I just copied what is already used.

> 
> > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:93
> > +        auto strongSelf = weakSelf.get();
> > +        if (strongSelf)
> 
> Nit: Could use:
> 
>         if ((auto strongSelf = weakSelf.get()))

Thanks!

[Dean Jackson]

Committed r231893: <https://trac.webkit.org/changeset/231893>