Summary: | Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||||||||
Component: | New Bugs | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, dbates, dino, ews-watchlist, realdawei, rniwa, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | Other | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Ryan Haddad
2018-05-16 15:11:02 PDT
This test was added in https://trac.webkit.org/changeset/230172/webkit Created attachment 342301 [details]
Patch
Comment on attachment 342301 [details] Patch Attachment 342301 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/8087634 New failing tests: accessibility/smart-invert-reference.html Created attachment 342331 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 342301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342301&action=review > LayoutTests/svg/dom/animated-tearoff-list-remove-target.html:54 > + }, 50); Are we waiting for the animation to occur? If so, can we make this more deterministic by using requestAnimationFrame instead? Created attachment 342349 [details]
Patch
Comment on attachment 342301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342301&action=review >> LayoutTests/svg/dom/animated-tearoff-list-remove-target.html:54 >> + }, 50); > > Are we waiting for the animation to occur? If so, can we make this more deterministic by using requestAnimationFrame instead? Yes. Done. Comment on attachment 342349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342349&action=review > LayoutTests/ChangeLog:22 > + Reviewed by NOBODY (OOPS!). This line should be before the description (line 7). Created attachment 342460 [details]
Patch
Created attachment 342468 [details]
Patch
Created attachment 342482 [details]
Patch
Comment on attachment 342482 [details] Patch Clearing flags on attachment: 342482 Committed r232736: <https://trac.webkit.org/changeset/232736> All reviewed patches have been landed. Closing bug. The test is no longer a flaky timeout, but now it is a flaky failure on iOS and macOS :( --- /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/svg/dom/animated-tearoff-list-remove-target-expected.txt +++ /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/svg/dom/animated-tearoff-list-remove-target-actual.txt @@ -1,4 +1,4 @@ Removing the target of an animate element should detach the wrappers of the attributes from their animated properties. +First tspan. +Second tspan -PASS. - https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r232770%20(10781)/results.html I think the issue is fixed by the followup patch: <https://trac.webkit.org/changeset/232780>. |