Bug 185685

Summary: [Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, beidson, commit-queue, sam, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2018-05-16 10:03:49 PDT
[Wi-Fi Assertions] Adopt WiFiAssertionHolderAdditions
Attachments
Patch (2.24 KB, patch)
2018-05-16 10:04 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2018-05-16 12:21 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-05-16 10:04:19 PDT
Created attachment 340497 [details] Patch
Andy Estes
Comment 2 2018-05-16 10:04:32 PDT
rdar://problem/40136681
Sam Weinig
Comment 3 2018-05-16 10:18:20 PDT
Comment on attachment 340497 [details] Patch I might use less generic names than holdAssertion()/releaseAssertion(), but otherwise, looks good.
Timothy Hatcher
Comment 4 2018-05-16 10:33:29 PDT
Comment on attachment 340497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340497&action=review > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:39 > + holdAssertion(); You will either need to add #if USE(APPLE_INTERNAL_SDK) around the call here or define empty stub functions above. > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:44 > + releaseAssertion(); Ditto.
Andy Estes
Comment 5 2018-05-16 12:07:12 PDT
(In reply to Timothy Hatcher from comment #4) > Comment on attachment 340497 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340497&action=review > > > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:39 > > + holdAssertion(); > > You will either need to add #if USE(APPLE_INTERNAL_SDK) around the call here > or define empty stub functions above. > > > Source/WebKit/NetworkProcess/cocoa/WiFiAssertionHolder.cpp:44 > > + releaseAssertion(); > > Ditto. Technically I don't need to due to how HAVE_MOBILE_WIFI is defined, but I agree this is the right way to do it, so I'll do it!
Andy Estes
Comment 6 2018-05-16 12:21:01 PDT
Created attachment 340513 [details] Patch
WebKit Commit Bot
Comment 7 2018-05-16 12:39:36 PDT
Comment on attachment 340513 [details] Patch Clearing flags on attachment: 340513 Committed r231863: <https://trac.webkit.org/changeset/231863>
WebKit Commit Bot
Comment 8 2018-05-16 12:39:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.