| Summary: | [LFC] Make Display::Box box sizing aware | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2018-05-15 08:55:35 PDT
Created attachment 340414 [details]
Patch
Comment on attachment 340414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340414&action=review > Source/WebCore/layout/displaytree/DisplayBox.h:90 > + Box(EBoxSizing); Won't this need some sort of more generic strategy at some point? Presumably there are other style-dependent things in Display::Boxes. (In reply to Antti Koivisto from comment #2) > Comment on attachment 340414 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340414&action=review > > > Source/WebCore/layout/displaytree/DisplayBox.h:90 > > + Box(EBoxSizing); > > Won't this need some sort of more generic strategy at some point? Presumably > there are other style-dependent things in Display::Boxes. Yeah, we definitely need some sort of more generic strategy for computed/resolved style values! (currently it's a combination of setters (padding, border) and through c'tor (box-sizing)). Comment on attachment 340414 [details] Patch Clearing flags on attachment: 340414 Committed r231846: <https://trac.webkit.org/changeset/231846> All reviewed patches have been landed. Closing bug. |