[LFC] Make Display::Box box sizing aware

[zalan]

box-sizing: content-box, border-box

[zalan]

Created attachment 340414 [details]
Patch

[Antti Koivisto]

Comment on attachment 340414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340414&action=review

> Source/WebCore/layout/displaytree/DisplayBox.h:90
> +    Box(EBoxSizing);

Won't this need some sort of more generic strategy at some point? Presumably there are other style-dependent things in Display::Boxes.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 340414 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340414&action=review
> 
> > Source/WebCore/layout/displaytree/DisplayBox.h:90
> > +    Box(EBoxSizing);
> 
> Won't this need some sort of more generic strategy at some point? Presumably
> there are other style-dependent things in Display::Boxes.
Yeah, we definitely need some sort of more generic strategy for computed/resolved style values! (currently it's a combination of setters (padding, border) and through c'tor (box-sizing)).

[WebKit Commit Bot]

Comment on attachment 340414 [details]
Patch

Clearing flags on attachment: 340414

Committed r231846: <https://trac.webkit.org/changeset/231846>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/40293626>