RESOLVED FIXED 185649
[LFC] Make Display::Box box sizing aware 
https://bugs.webkit.org/show_bug.cgi?id=185649
Summary [LFC] Make Display::Box box sizing aware
zalan
Reported 2018-05-15 08:55:35 PDT
box-sizing: content-box, border-box
Attachments
Patch (5.73 KB, patch)
2018-05-15 09:03 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-05-15 09:03:09 PDT
Created attachment 340414 [details] Patch
Antti Koivisto
Comment 2 2018-05-16 02:14:48 PDT
Comment on attachment 340414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340414&action=review > Source/WebCore/layout/displaytree/DisplayBox.h:90 > + Box(EBoxSizing); Won't this need some sort of more generic strategy at some point? Presumably there are other style-dependent things in Display::Boxes.
zalan
Comment 3 2018-05-16 07:21:08 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 340414 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340414&action=review > > > Source/WebCore/layout/displaytree/DisplayBox.h:90 > > + Box(EBoxSizing); > > Won't this need some sort of more generic strategy at some point? Presumably > there are other style-dependent things in Display::Boxes. Yeah, we definitely need some sort of more generic strategy for computed/resolved style values! (currently it's a combination of setters (padding, border) and through c'tor (box-sizing)).
WebKit Commit Bot
Comment 4 2018-05-16 07:50:00 PDT
Comment on attachment 340414 [details] Patch Clearing flags on attachment: 340414 Committed r231846: <https://trac.webkit.org/changeset/231846>
WebKit Commit Bot
Comment 5 2018-05-16 07:50:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-05-16 07:50:22 PDT
<rdar://problem/40293626>
Note You need to log in before you can comment on or make changes to this bug.