Bug 185648

Summary: Update animation when presenting QuickLook
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch graouts: review+

Description Dean Jackson 2018-05-15 03:21:19 PDT
Update animation when presenting QuickLook
Comment 1 Dean Jackson 2018-05-15 03:21:54 PDT
<rdar://problem/39652624>
Comment 2 Dean Jackson 2018-05-15 03:25:19 PDT
Created attachment 340402 [details]
Patch
Comment 3 Antoine Quint 2018-05-15 03:29:24 PDT
Comment on attachment 340402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review

> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142
> +    frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10);

You should make 10 a named constant and replace 5 with half that value.
Comment 4 Dean Jackson 2018-05-15 03:30:07 PDT
Comment on attachment 340402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review

>> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142
>> +    frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10);
> 
> You should make 10 a named constant and replace 5 with half that value.

I think I'll make the rect 50% of the width and height instead.
Comment 5 Dean Jackson 2018-05-15 03:37:38 PDT
Committed r231797: <https://trac.webkit.org/changeset/231797>