Bug 185648

Summary: Update animation when presenting QuickLook
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch graouts: review+

Dean Jackson
Reported 2018-05-15 03:21:19 PDT
Update animation when presenting QuickLook
Attachments
Patch (2.71 KB, patch)
2018-05-15 03:25 PDT, Dean Jackson 		graouts: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2018-05-15 03:21:54 PDT
<rdar://problem/39652624>
Dean Jackson
Comment 2 2018-05-15 03:25:19 PDT
Created attachment 340402 [details] Patch
Antoine Quint
Comment 3 2018-05-15 03:29:24 PDT
Comment on attachment 340402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142 > + frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10); You should make 10 a named constant and replace 5 with half that value.
Dean Jackson
Comment 4 2018-05-15 03:30:07 PDT
Comment on attachment 340402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review >> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142 >> + frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10); > > You should make 10 a named constant and replace 5 with half that value. I think I'll make the rect 50% of the width and height instead.
Dean Jackson
Comment 5 2018-05-15 03:37:38 PDT
Committed r231797: <https://trac.webkit.org/changeset/231797>
Note You need to log in before you can comment on or make changes to this bug.