Bug 185619

Summary:

Exit fullscreen when javascript alerts are presented.

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

WebKit2

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, jer.noble, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews204 for win-future	none
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

Jeremy Jones

Reported 2018-05-14 12:10:24 PDT

Exit fullscreen when javascript alerts are presented.

Attachments
Patch (3.81 KB, patch) 2018-05-14 12:30 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.77 MB, application/zip) 2018-05-14 15:24 PDT, EWS Watchlist	no flags	Details
Patch (8.75 KB, patch) 2018-05-25 05:49 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (22.59 MB, application/zip) 2018-05-25 07:38 PDT, EWS Watchlist	no flags	Details
Patch (3.85 KB, patch) 2018-06-01 09:39 PDT, Jeremy Jones	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jeremy Jones

Comment 1 2018-05-14 12:16:49 PDT

rdar://problem/35724264

Jeremy Jones

Comment 2 2018-05-14 12:30:03 PDT

Created attachment 340341 [details] Patch

EWS Watchlist

Comment 3 2018-05-14 15:24:31 PDT

Comment on attachment 340341 [details] Patch Attachment 340341 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7682039 New failing tests: http/tests/preload/onload_event.html

EWS Watchlist

Comment 4 2018-05-14 15:24:41 PDT

Created attachment 340367 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Alexey Proskuryakov

Comment 5 2018-05-16 20:26:00 PDT

*** Bug 185618 has been marked as a duplicate of this bug. ***

Jeremy Jones

Comment 6 2018-05-25 05:49:48 PDT

Created attachment 341274 [details] Patch

EWS Watchlist

Comment 7 2018-05-25 07:38:19 PDT

Comment on attachment 341274 [details] Patch Attachment 341274 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7799244 New failing tests: fullscreen/full-screen-exit-when-alert.html

EWS Watchlist

Comment 8 2018-05-25 07:38:21 PDT

Created attachment 341280 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Jeremy Jones

Comment 9 2018-06-01 09:39:11 PDT

Created attachment 341765 [details] Patch

Jer Noble

Comment 10 2018-06-01 10:52:40 PDT

Comment on attachment 341765 [details] Patch WK1? We should be able to write an API test for this.

Jeremy Jones

Comment 11 2018-06-01 15:21:48 PDT

(In reply to Jer Noble from comment #10) > Comment on attachment 341765 [details] > Patch > > WK1? We should be able to write an API test for this. This feature is WK2 iOS only.

WebKit Commit Bot

Comment 12 2018-06-02 09:02:20 PDT

Comment on attachment 341765 [details] Patch Clearing flags on attachment: 341765 Committed r232437: <https://trac.webkit.org/changeset/232437>

WebKit Commit Bot

Comment 13 2018-06-02 09:02:22 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.