Bug 185609

Summary: Renaming of overrides in RenderBox
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2018-05-14 07:12:06 PDT
Renaming of overrides in LayoutBox
Attachments
Patch (51.84 KB, patch)
2018-05-14 07:12 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2018-05-14 07:12:37 PDT
Created attachment 340309 [details] Patch
Manuel Rego Casasnovas
Comment 2 2018-05-14 07:19:42 PDT
This is just a renaming, I'll try to fix the FIXME in LayoutBox in follow-up patches.
WebKit Commit Bot
Comment 3 2018-05-14 08:20:52 PDT
Comment on attachment 340309 [details] Patch Clearing flags on attachment: 340309 Committed r231757: <https://trac.webkit.org/changeset/231757>
WebKit Commit Bot
Comment 4 2018-05-14 08:20:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-05-14 08:21:27 PDT
<rdar://problem/40217955>
alan
Comment 6 2018-05-14 09:02:46 PDT
(In reply to Manuel Rego Casasnovas from comment #0) > Renaming of overrides in LayoutBox What is a LayoutBox?
alan
Comment 7 2018-05-14 09:04:54 PDT
(In reply to zalan from comment #6) > (In reply to Manuel Rego Casasnovas from comment #0) > > Renaming of overrides in LayoutBox > > What is a LayoutBox? guess this is some leftover from a blink patch.
Manuel Rego Casasnovas
Comment 8 2018-05-14 13:38:25 PDT
(In reply to zalan from comment #6) > (In reply to Manuel Rego Casasnovas from comment #0) > > Renaming of overrides in LayoutBox > > What is a LayoutBox? Ooops sorry, this is becuase we're doing things in both Blink and WebKit, and now in Blink RenderBox is called LayoutBox. Should I do a quick patch fixing the ChangeLog or not?
alan
Comment 9 2018-05-14 13:42:37 PDT
(In reply to Manuel Rego Casasnovas from comment #8) > (In reply to zalan from comment #6) > > (In reply to Manuel Rego Casasnovas from comment #0) > > > Renaming of overrides in LayoutBox > > > > What is a LayoutBox? > > Ooops sorry, this is becuase we're doing things in both Blink and WebKit, > and now in Blink RenderBox is called LayoutBox. > > Should I do a quick patch fixing the ChangeLog or not? nah. It's fine. I was just a bit surprised (especially since I also started using LayoutBox in webcore/layout)
Note You need to log in before you can comment on or make changes to this bug.