Bug 185609 - Renaming of overrides in RenderBox
Summary: Renaming of overrides in RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-05-14 07:12 PDT by Manuel Rego Casasnovas
Modified: 2018-05-14 13:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (51.84 KB, patch)
2018-05-14 07:12 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2018-05-14 07:12:06 PDT 
Renaming of overrides in LayoutBox
Comment 1 Manuel Rego Casasnovas 2018-05-14 07:12:37 PDT 
Created attachment 340309 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2018-05-14 07:19:42 PDT 
This is just a renaming, I'll try to fix the FIXME in LayoutBox in follow-up patches.
Comment 3 WebKit Commit Bot 2018-05-14 08:20:52 PDT 
Comment on attachment 340309 [details]
Patch

Clearing flags on attachment: 340309

Committed r231757: <https://trac.webkit.org/changeset/231757>
Comment 4 WebKit Commit Bot 2018-05-14 08:20:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-05-14 08:21:27 PDT 
<rdar://problem/40217955>
Comment 6 zalan 2018-05-14 09:02:46 PDT 
(In reply to Manuel Rego Casasnovas from comment #0)
> Renaming of overrides in LayoutBox

What is a LayoutBox?
Comment 7 zalan 2018-05-14 09:04:54 PDT 
(In reply to zalan from comment #6)
> (In reply to Manuel Rego Casasnovas from comment #0)
> > Renaming of overrides in LayoutBox
> 
> What is a LayoutBox?
guess this is some leftover from a blink patch.
Comment 8 Manuel Rego Casasnovas 2018-05-14 13:38:25 PDT 
(In reply to zalan from comment #6)
> (In reply to Manuel Rego Casasnovas from comment #0)
> > Renaming of overrides in LayoutBox
> 
> What is a LayoutBox?

Ooops sorry, this is becuase we're doing things in both Blink and WebKit,
and now in Blink RenderBox is called LayoutBox.

Should I do a quick patch fixing the ChangeLog or not?
Comment 9 zalan 2018-05-14 13:42:37 PDT 
(In reply to Manuel Rego Casasnovas from comment #8)
> (In reply to zalan from comment #6)
> > (In reply to Manuel Rego Casasnovas from comment #0)
> > > Renaming of overrides in LayoutBox
> > 
> > What is a LayoutBox?
> 
> Ooops sorry, this is becuase we're doing things in both Blink and WebKit,
> and now in Blink RenderBox is called LayoutBox.
> 
> Should I do a quick patch fixing the ChangeLog or not?
nah. It's fine. I was just a bit surprised (especially since I also started using LayoutBox in webcore/layout)