Bug 185600

Summary: Make all SVG shape interfaces inherit from SVGGeometryElement
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 184767    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Dirk Schulze 2018-05-13 20:55:48 PDT 
Make all SVG shape interfaces inherit from SVGGeometryElement as defined by SVG2.

https://svgwg.org/svg2-draft/shapes.html#DOMInterfaces
Comment 1 Dirk Schulze 2018-05-13 21:17:41 PDT 
Created attachment 340288 [details]
Patch
Comment 2 Antti Koivisto 2018-05-16 23:35:38 PDT 
Comment on attachment 340288 [details]
Patch

r=me
Comment 3 Antti Koivisto 2018-05-16 23:37:40 PDT 
Comment on attachment 340288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340288&action=review

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:362
> +    bool isValid;
> +    point = m_path->pointAtLength(distance, isValid);

What happens when the point is not valid? Is this covered by the tests?
Comment 4 Dirk Schulze 2018-05-18 07:38:07 PDT 
Created attachment 340694 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-05-18 08:23:01 PDT 
Comment on attachment 340694 [details]
Patch for landing

Clearing flags on attachment: 340694

Committed r231955: <https://trac.webkit.org/changeset/231955>
Comment 6 WebKit Commit Bot 2018-05-18 08:23:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-18 08:24:17 PDT 
<rdar://problem/40365807>