Summary: | [LFC] Implement height computation for non-replaced out of flow elements. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2018-05-12 22:12:49 PDT
Created attachment 340255 [details]
Patch
Created attachment 340278 [details]
Patch
Created attachment 340282 [details]
Patch
Comment on attachment 340282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340282&action=review > Source/WebCore/layout/FormattingContext.cpp:180 > + computedHeightValue= contentHeightForFormattingContextRoot(layoutContext, layoutBox); Missing space before = > Source/WebCore/layout/FormattingContext.cpp:207 > + if (!is<Container>(layoutBox) || !downcast<Container>(layoutBox).hasInFlowOrFloatingChild()) { > + return 0; > } Unneeded { } Created attachment 340318 [details]
Patch
Comment on attachment 340318 [details] Patch Clearing flags on attachment: 340318 Committed r231758: <https://trac.webkit.org/changeset/231758> All reviewed patches have been landed. Closing bug. |