Bug 185585

Summary: [LFC] Implement height computation for non-replaced out of flow elements.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2018-05-12 22:12:49 PDT
ssia
Attachments
Patch (11.52 KB, patch)
2018-05-12 22:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.50 KB, patch)
2018-05-13 14:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.50 KB, patch)
2018-05-13 18:51 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.07 KB, patch)
2018-05-14 08:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-05-12 22:25:03 PDT
Created attachment 340255 [details] Patch
alan
Comment 2 2018-05-13 14:22:56 PDT
Created attachment 340278 [details] Patch
alan
Comment 3 2018-05-13 18:51:03 PDT
Created attachment 340282 [details] Patch
Antti Koivisto
Comment 4 2018-05-14 00:10:09 PDT
Comment on attachment 340282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340282&action=review > Source/WebCore/layout/FormattingContext.cpp:180 > + computedHeightValue= contentHeightForFormattingContextRoot(layoutContext, layoutBox); Missing space before = > Source/WebCore/layout/FormattingContext.cpp:207 > + if (!is<Container>(layoutBox) || !downcast<Container>(layoutBox).hasInFlowOrFloatingChild()) { > + return 0; > } Unneeded { }
alan
Comment 5 2018-05-14 08:32:31 PDT
Created attachment 340318 [details] Patch
WebKit Commit Bot
Comment 6 2018-05-14 09:00:02 PDT
Comment on attachment 340318 [details] Patch Clearing flags on attachment: 340318 Committed r231758: <https://trac.webkit.org/changeset/231758>
WebKit Commit Bot
Comment 7 2018-05-14 09:00:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-05-14 09:01:43 PDT
<rdar://problem/40218919>
Note You need to log in before you can comment on or make changes to this bug.