Bug 185556

Summary: [GTK] Silence GCC 8 warnings
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, aperez, apinheiro, berto, bugs-noreply, cfleizach, cgarcia, dmazzoni, ews-watchlist, gustavo, jcraig, jdiggs, mcatanzaro, samuel_white, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch zan: review+

Description Michael Catanzaro 2018-05-11 11:42:27 PDT 
Silence GCC 8 warnings. Having already done this for WPE, there's not much more left to do.

Notably, Adrian, you were wrong about the C style casts. The double cast is needed there too.
Comment 1 Michael Catanzaro 2018-05-11 11:48:03 PDT 
Created attachment 340209 [details]
Patch
Comment 2 Adrian Perez 2018-05-11 14:47:30 PDT 
(In reply to Michael Catanzaro from comment #0)
> Silence GCC 8 warnings. Having already done this for WPE, there's not much
> more left to do.
> 
> Notably, Adrian, you were wrong about the C style casts. The double cast is
> needed there too.

Well, one has to be proven wrong now and than, and that's fine.
Double-cast it is, then! FWIW, I quickly tested the patch and
works here, so it seems fine to me.
Comment 3 Michael Catanzaro 2018-05-21 08:29:28 PDT 
Ping reviewers
Comment 4 Michael Catanzaro 2018-05-23 10:50:51 PDT 
Committed r232118: <https://trac.webkit.org/changeset/232118>