Bug 185542

Summary: Network process should not stat() all cache files on startup to find their sizes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, cgarcia, commit-queue, ews-watchlist
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
cdumez: review+
patch none

Antti Koivisto
Reported 2018-05-11 00:38:45 PDT
We can estimate the records sizes to avoid lots of CPU use and I/O under stat().
Attachments
patch (5.58 KB, patch)
2018-05-11 01:14 PDT, Antti Koivisto 		cdumez: review+
DetailsFormatted DiffDiff
patch (5.58 KB, patch)
2018-05-11 10:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-05-11 00:39:50 PDT
<rdar://problem/40092953>
Antti Koivisto
Comment 2 2018-05-11 01:14:07 PDT
Created attachment 340178 [details] patch
Chris Dumez
Comment 3 2018-05-11 10:27:32 PDT
Comment on attachment 340178 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=340178&action=review > Source/WebKit/ChangeLog:12 > + Large bodies are saved in seprate blob files so record file sizes are capped. We can avoid work by typo: seprate
Antti Koivisto
Comment 4 2018-05-11 10:32:54 PDT
Created attachment 340197 [details] patch
WebKit Commit Bot
Comment 5 2018-05-11 11:11:27 PDT
Comment on attachment 340197 [details] patch Clearing flags on attachment: 340197 Committed r231708: <https://trac.webkit.org/changeset/231708>
WebKit Commit Bot
Comment 6 2018-05-11 11:11:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.