Bug 185523

Summary:

Renamed "trackNetworkActivity" to "tracksResourceLoadMilestone"

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

WebKit Misc.

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-watchlist, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none
Archive of layout-test-results from ews200 for win-future	none

Description Keith Rollin 2018-05-10 12:04:02 PDT

Follow on to Bug 184838, comment 17.

Note that that comment recommends incorporating the verb "should", but Geoff recommended against that, so I'm going with "tracks".

Comment 1 Radar WebKit Bug Importer 2018-05-10 12:04:17 PDT

<rdar://problem/40136361>

Comment 2 Keith Rollin 2018-05-10 12:08:58 PDT

Created attachment 340116 [details]
Patch

Comment 3 Chris Dumez 2018-05-10 12:17:08 PDT

Comment on attachment 340116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340116&action=review

> Source/WebKit/ChangeLog:3
> +        Renamed "trackNetworkActivity" to "tracksResourceLoadMilestone"

tracksResourceLoadMilestones

Comment 4 EWS Watchlist 2018-05-10 14:17:51 PDT

Comment on attachment 340116 [details]
Patch

Attachment 340116 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7642144

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
http/tests/preload/onload_event.html

Comment 5 EWS Watchlist 2018-05-10 14:18:04 PDT

Created attachment 340130 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 6 Keith Rollin 2018-05-17 12:18:47 PDT

Created attachment 340622 [details]
Patch

Comment 7 EWS Watchlist 2018-05-18 07:20:51 PDT

Comment on attachment 340622 [details]
Patch

Attachment 340622 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7721704

New failing tests:
http/tests/preload/onload_event.html

Comment 8 EWS Watchlist 2018-05-18 07:21:02 PDT

Created attachment 340692 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 9 Geoffrey Garen 2018-05-18 10:34:31 PDT

Comment on attachment 340622 [details]
Patch

r=me

Comment 10 WebKit Commit Bot 2018-05-18 11:17:33 PDT

Comment on attachment 340622 [details]
Patch

Clearing flags on attachment: 340622

Committed r231966: <https://trac.webkit.org/changeset/231966>

Comment 11 WebKit Commit Bot 2018-05-18 11:17:35 PDT

All reviewed patches have been landed.  Closing bug.